Closed Bug 425466 Opened 17 years ago Closed 5 years ago

CreateSearchResultIterator fails, this code will crash

Categories

(MailNews Core :: Networking: IMAP, defect)

Product:
MailNews Core
Component:
Networking: IMAP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: mkmelin, Unassigned)

References

(
URL
)

Details

(Keywords: crash, Whiteboard: [not critical])

timeless in bug 341929 comment 3 2. http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/imap/src/nsImapProtocol.cpp&rev=1.612.2.3.4.1&mark=4844,4845,5426-5427,5428#5400 when CreateSearchResultIterator fails, this code will crash (this could actually give the stack you have)
Summary: fSearchResults = nsImapSearchResultSequence::CreateSearchResultSequence() isn't null checked → CreateSearchResultIterator fails, this code will crash
Product: Core → MailNews Core
(In reply to comment #0) > timeless in bug 341929 comment 3 > > 2. > http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/imap/src/nsImapProtocol.cpp&rev=1.612.2.3.4.1&mark=4844,4845,5426-5427,5428#5400 > when CreateSearchResultIterator fails, this code will crash (this could > actually give the stack you have) this code is unchanged, so ver=trunk. http://mxr.mozilla.org/comm-central/source/mailnews/imap/src/nsImapProtocol.cpp#6028
Version: 1.8 Branch → Trunk
So this just needs error checking whether the returned value is not null?
(In reply to :aceman from comment #2) > So this just needs error checking whether the returned value is not null?
My understanding was that OOM currently makes the app exit anyway, and OOM is the only reason that we'd get a null return value.
(In reply to David :Bienvenu from comment #4) > My understanding was that OOM currently makes the app exit anyway, and OOM > is the only reason that we'd get a null return value. demoting based on this assessment
Assignee: mozilla → nobody
Severity: critical → normal
Whiteboard: [not critical]
Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.

Would not be reached today.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.