Changes to attachment flags show up as "Attachment #294955 [details] [diff]Flag". This is due to how the fielddefs stuff is munged. Patch coming

(Well, without the [details] bit.....)

Its a bit ugly (specifically, the lcfirst breaks if theres ever an acronym at the start of the sentence), but fielddefs aren't localisable ATM anyway, so....

Comment on attachment 312199 [details] [diff] [review] Patch >Index: Bugzilla/Bug.pm >+ if ($attachid) { >+ $field =~ s/^Attachment\s*//; >+ # Really ugly, but gives consistent results >+ $field = lcfirst($field); >+ } This is overkill. We don't need that. Having fields with the first letter of *each* word uppercase is fine. >Index: template/en/default/bug/activity/table.html.tmpl >- Attachment #[% change.attachid %]</a> >+ Attachment #[% change.attachid %]</a>[% " " %] > [% END %] > [% change.field %] No, that's a hack. Simply write [%+ change.field %] instead.

a) Yeah, but because of how fielddefs work you get: Attachment #1 [details] [diff] mime type Attachment #1 [details] [diff] filename Attachment #1 [details] [diff] Flag Of course, MIME should be upper case, which would break this too. Do we care that its inconsistent? b) I was trying to avoid extra spaces for non-attachment bits (the END is the end of an IF), but I guess its HTML so doesn't really matter

(In reply to comment #4) > a) Yeah, but because of how fielddefs work you get: > [...] Do we care that its inconsistent? Completely. > b) I was trying to avoid extra spaces for non-attachment bits (the END is the > end of an IF), but I guess its HTML so doesn't really matter HTML doesn't matter and ignores the leading whitespaces, because both solutions below are equivalent: <td>Foo</td> <td> Foo </td>

* LpSolit has much more critical bugs to deal with than having "flag" lowercase in show activity :-p

Comment on attachment 312250 [details] [diff] [review] patch v2 r=LpSolit

Checked in to trunk + branch

(In reply to comment #8) > Checked in to trunk + branch Please paste new rev. numbers. Else it's a pain to track changes.