Closed Bug 426596 Opened 17 years ago Closed 2 years ago

Right Click Popup Context Menu broken with textbox

Categories

(Toolkit :: XUL Widgets, defect)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: scott.turner, Unassigned)

Details

(Keywords: regression)

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_2; en-us) AppleWebKit/525.13 (KHTML, like Gecko) Version/3.1 Safari/525.13 Build Identifier: head Cross platform tested with latest nightly builds as well as beta 4 i.e. has been hanging around for a couple beta releases. Problem is with toolkit/content/widgets/textbox.xml. In <binding id="input-box"> If you remove this.parentNode._doPopupItemEnabling(this); from onpopupshowing="" you can sometimes get it to work. Problem appears to be in: <implementation> <method name="_doPopupItemEnabling"> ... var controller = document.commandDispatcher.getControllerForComm and(command); The call to getControllerForCommand is never returning a value. The result is the popup context menu items don't work when clicked. Reproducible: Always Steps to Reproduce: 1. Run test2.xul 2. Right click on textbox 3. Click on select all from pop up context menu Actual Results: Select all (or any other item from popup context menu) doesn't happen. Expected Results: Text should have been selected (or copy, pasted etc...) The key bindings work e.g. Ctrl-A, Ctrl-X etc...
Version: unspecified → Trunk
confirming with Beta5
Status: UNCONFIRMED → NEW
Ever confirmed: true
Doesn't work in 1.8 though either. Presumably, the command dispatcher isn't accessible in non-chrome code.
Component: Menus → XUL Widgets
Product: Firefox → Toolkit
QA Contact: menus → xul.widgets
Dup of bug 321879?
Flags: blocking1.9?
Keywords: regression
If it's not a regression, we won't block at this point. However, wanted-next+.
Flags: wanted-next+
Flags: blocking1.9?
Flags: blocking1.9-
Absolutely a dup of 321879, (although this one has a nice testcase), therefore dependent on 59701, and probably hopeless for wanted-next.
(Crossposting from bug 321879) Since this bug isn't likely to be fixed anytime soon we have created a band-aid XBL for our remote XUL project that others might find interesting. The binding permanently disables the broken Undo, Cut, Copy, and Paste items for the application and re-enables Delete and Select All. If you rather not want to include the disabled options at all then modifying the XBL is trivial (simply remove the menuitems you don't want). Textbox context menus without the XBL: http://193.180.78.90/.demo/nx2-1.0-beta9/ui/xul-login.php Textbox context menus with the XBL: http://193.180.78.90/.demo/nx2/ui/xul-login.php (Username is a normal textbox, Password is a password type textbox, and the multi-line textbox is read-only thus "Delete" will stay disabled even when there's text in it). The XBL itself: http://193.180.78.90/.demo/nx2/ui/layout/nx2.xml To add it to your project, simply download nx2.xml and add a stylesheet with the rule: .textbox-input-box { -moz-binding:url('nx2.xml#textbox'); } While the XBL is as simple as we could write it and has been peer reviewed by Ratty (thanks!), who also encouraged it being attached to this bug, it's naturally provided "as is" without any warranty :-)

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Severity: major → --
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: