This bug is meant as the simple version of fixing bug 416514 and bug 416515. Rationale for the change is listed in those bugs. Quick fix: 1) Remove the favicon from bookmarks.html so that it picks up a generic favicon (which is both platform specific, and isn't bright red) 2) make sure that the getting started page does not specify the dino head favicon so that it continues to use the generic favicon Adding the late-l10n keyword since I am pretty sure we would need to modify the bookmarks.html files for every local. There is no translation going on, just removing cdata.

Sadly I don't have better tools than perl or python to aid here. If we do this, we might actually do it in the baking time, so that we'd be exposed to a lower risk of localizers overwriting that change. I'd like to add that the favicons in bookmarks.html are part of the compare-locales-checked content, at least on the buildbot part, so if we'd do this without an l10n patch, we'd turn those builds orange.

Requesting blocking for 3.1. We are spending a tremendous amount of time, effort and overall resources polishing every surrounding icon in our interface, and yet we still have a bright red dinosaur in our default UI. The only reason we don't all think this looks visually jarring and metaphorically strange is because we are so used to seeing it.

this bug is eligible for bug 462080

So would we just remove everything within the quotes of 'ICON=""' or remove the complete line including 'ICON=""'?

This will merge-conflict with bug 461979. I have a patch for that, need to test the try server builds still.

This removes the icon from the bookmarks file; we'll want to file another bug against IT to actually remove it from the page on the server, otherwise it's just going to come back :)

Axel, if you can merge that change along with the other localization changes you're making, that'd be awesome :)

Comment on attachment 347240 [details] [diff] [review] bye bye barney poor barney, but his time has come.

Axel: were you going to be able to get to this?

Yes, bug 461979 landed without barney on both central and 1.9.1, http://hg.mozilla.org/releases/mozilla-1.9.1/rev/dd4e20904f67. Marking this FIXED and fixed1.9.1.

Hi, maybe im not understanding this fix, or its not in yet, but i still see the dino head in the favicon on http://en-us.www.mozilla.com/en-US/firefox/central/. Should i be seeing something else? Jus' Trying to verify the fix on trunk and branch.

(In reply to comment #11) > Created an attachment (id=358346) [details] > dino favicon screenshot > > Hi, maybe im not understanding this fix, or its not in yet, but i still see the > dino head in the favicon on > http://en-us.www.mozilla.com/en-US/firefox/central/. Should i be seeing > something else? > > Jus' Trying to verify the fix on trunk and branch. Oh, this was on both: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090122 Minefield/3.2a1pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090122 Shiretoko/3.1b3pre

That the page itself has the dino favicon is bug 416514. This bug is really only about Barney not showing up in the personal toolbar folder, at least on startup, and that's what your screen shot shows.

Verified with the understanding that Barney does not appear only so long as you haven't visited the Getting Started page. Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1b3pre) Gecko/20090130 Shiretoko/3.1b3pre

This bug's priority relative to the set of other polish bugs is: P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day. This polish issue effected the main window in the upper left (most visible area), the bug was also a kind of glaring bright red.