The RTL Profile Wizard on Linux has at the bottom two buttons with arrows for next and backward. We should get them mirrored in RTL mode.

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).

This patch causes the wizard widget to use the RTL or LTR specific versions of the go-back and go-forward icons.

Comment on attachment 359994 [details] [diff] [review] Patch (v1) > <xul:button label="&button-next-unix.label;" accesskey="&button-next-unix.accesskey;" > > class="wizard-button" dlgtype="next" icon="go-forward" > >- default="true" flex="1"/> > >+ chromedir="&locale.dir;" default="true" flex="1"/> > <xul:button label="&button-next-win.label;" accesskey="&button-next-win.accesskey;" > > class="wizard-button" dlgtype="next" icon="go-forward" > >- default="true" flex="1"/> > >+ chromedir="&locale.dir;" default="true" flex="1"/> superfluous spaces after />

Comment on attachment 359994 [details] [diff] [review] Patch (v1) Another theme-only and low risk patch which is nice to have for RTL locales.

Comment on attachment 359994 [details] [diff] [review] Patch (v1) a191=beltzner

I don't like what was done here - you've basically checked in code which was denied long ago by "gtk peers" (see bug 289886) without even getting a toolkit peer review (there's no such thing "theme only", esp. not when toolkit/content/widgets is in your way).

For future reference: http://www.mozilla.org/projects/toolkit/review.html Theme-*only* changes policy is a little less strict in certain cases (clean up, and in cases like this I would still indeed for a first-review from someone who can test it).

It's technically different code. Bug 289886 used gtk-go-back where this uses gtk-go-forward-rtl.

That's all good. I think though that part of the sr- was on using chromedir for choosing a -moz-apperance rather than detrcing the direction on the back-end side). Having all that said Dão, my last comments stands - peer reviews are required for all toolkit/content/widgets checkins.

Sorry for messing up here. I backed out the patch on both trunk and 1.9.1 branch.

Comment on attachment 359994 [details] [diff] [review] Patch (v1) OK...

Landed again on mozilla-central: <http://hg.mozilla.org/mozilla-central/rev/5c8cf652ca93>

Comment on attachment 359994 [details] [diff] [review] Patch (v1) Requesting approval again. This is the same patch which was approved before for 1.9.1.

Comment on attachment 359994 [details] [diff] [review] Patch (v1) a191=beltzner, please add a Litmus test?

(In reply to comment #17) > (From update of attachment 359994 [details] [diff] [review]) > a191=beltzner, please add a Litmus test? We're in the process of adding Litmus tests for many of the RTL bugs including this one.

This bug's priority relative to the set of other polish bugs is: P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.