Closed Bug 428299 Opened 17 years ago Closed 15 years ago

Main window text fields should be transparent when using Glass

Categories

(Firefox :: Theme, enhancement)

x86
Windows 7
enhancement
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3.7a4

People

(Reporter: faaborg, Assigned: dao)

References

Details

(Keywords: polish, Whiteboard: [polish-easy][polish-interactive][polish-p1])

Attachments

(1 file)

On Vista the main text fields in applications are slightly gray. The color lightens on mouse hover, and then the fields change to white when focused. The colors vary slightly throughout the field due to the fact that they are slightly transparent and the glass shine effect also overlays the color. When placed on a white background, here are colors for each state that often appear in the field: Normal: (239, 245, 252) Hover: (249,252,254) Focused: (255,255,255)
The easy way: #navigator-toolbox textbox { opacity: .8; } #navigator-toolbox textbox:hover { opacity: .9; } #navigator-toolbox textbox[focused="true"] { opacity: 1; } However, I suspect Vista doesn't actually fade whole textboxes but only their background.
(In reply to comment #1) > However, I suspect Vista doesn't actually fade whole textboxes but only their > background. I can confirm that Vista only fades the background. The text colors stays. As I mentioned before somewhere, you can't apply alpha values to system colors, for example, applying rgba(-moz-field, .8) to the background of textfield.
It could be done with a XUL stack.
Isn't that too much of a hack?
Not necessarily, but I think it's too late to do that now.
Enn, Vlad: are these states part of the textbox object in Vista? Is the right fix here to look into pulling those states forward?
Flags: wanted-firefox3+
I think the "correct" style for this is actually a background image stored in AB::AddressBand (there's even ABRed, ABYellow, and ABGreen if you really wanted to follow IE). But the images are just rgba(255,255,255,185), rgba(255,255,255,229) and rgba(255,255,255,255) with a little 2px white and black border around them. Someone did a lot of digging putting names with images in areo.msstyles over at: http://www.aeroxp.org/wiki/aeromsstyles/
Keywords: polish
Whiteboard: [polish-easy][polish-interactive]
We probably want to land this at the same time as using Aero glass. Added the polish whiteboard terms just for tracking.
Changed my mind on the landing at the same time as Aero glass: I want us to hard code the appearance of the textfield to make it look right for Aero (similar to how we create the location bar field on OS X), using the css selector for when we know the user has the Aero theme.
(In reply to comment #9) > I want us to > hard code the appearance of the textfield to make it look right for Aero > (similar to how we create the location bar field on OS X), using the css > selector for when we know the user has the Aero theme. Comment 7 describes the right way to fix this.
Component: Theme → Widget: Win32
Flags: wanted-firefox3+
Product: Firefox → Core
QA Contact: theme → win32
To clarify, this color changing of the text fields applies only to text fields on glass, right? Also, the link in comment 7 doesn't work.
(In reply to comment #11) > To clarify, this color changing of the text fields applies only to text fields > on glass, right? I think that's MS' idea, but not necessarily what we want to do, since (AFAIK) we're not going to use aero glass for the main window anytime soon. > Also, the link in comment 7 doesn't work. http://web.archive.org/web/20071126134023/http://www.aeroxp.org/wiki/aeromsstyles It says this: [IMAGE.572.1033] AB::AddressBand.Background..Image=Image Query Builder.Background Spray..Image=Image
In the case of windows mail and windows calendar, we see this behavior for the fields when not on glass. However, other fields that are in more of the content area, like the search fields in media player and photo gallery, do not have this effect.
There's also ABComposited::AddressBand and SearchBoxComposited::SearchBox.
This bug's priority relative to the set of other polish bugs is: P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day. impacts the main window, and a very common control
Whiteboard: [polish-easy][polish-interactive] → [polish-easy][polish-interactive][polish-p1]
This is quite easy to do in the theme with the new location and search bar style.
Component: Widget: Win32 → Theme
OS: Windows Vista → Windows 7
Product: Core → Firefox
QA Contact: win32 → theme
Summary: Vista main window text field hover and selection behavior → Main window text fields should be transparent when using Glass
Attached patch patch (deleted) — Splinter Review
This uses the alpha values from comment 7.
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #434827 - Flags: review?(rflint)
Attachment #434827 - Flags: review?(rflint) → review+
Severity: normal → enhancement
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a4
Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100327 Minefield/3.7a4pre
Status: RESOLVED → VERIFIED
Depends on: 590931
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: