Closed
Bug 428299
Opened 17 years ago
Closed 15 years ago
Main window text fields should be transparent when using Glass
Categories
(Firefox :: Theme, enhancement)
Tracking
()
VERIFIED
FIXED
Firefox 3.7a4
People
(Reporter: faaborg, Assigned: dao)
References
Details
(Keywords: polish, Whiteboard: [polish-easy][polish-interactive][polish-p1])
Attachments
(1 file)
(deleted),
patch
|
rflint
:
review+
|
Details | Diff | Splinter Review |
On Vista the main text fields in applications are slightly gray. The color lightens on mouse hover, and then the fields change to white when focused.
The colors vary slightly throughout the field due to the fact that they are slightly transparent and the glass shine effect also overlays the color. When placed on a white background, here are colors for each state that often appear in the field:
Normal: (239, 245, 252)
Hover: (249,252,254)
Focused: (255,255,255)
Assignee | ||
Comment 1•17 years ago
|
||
The easy way:
#navigator-toolbox textbox {
opacity: .8;
}
#navigator-toolbox textbox:hover {
opacity: .9;
}
#navigator-toolbox textbox[focused="true"] {
opacity: 1;
}
However, I suspect Vista doesn't actually fade whole textboxes but only their background.
Comment 2•17 years ago
|
||
(In reply to comment #1)
> However, I suspect Vista doesn't actually fade whole textboxes but only their
> background.
I can confirm that Vista only fades the background. The text colors stays. As I mentioned before somewhere, you can't apply alpha values to system colors, for example, applying rgba(-moz-field, .8) to the background of textfield.
Assignee | ||
Comment 3•17 years ago
|
||
It could be done with a XUL stack.
Comment 4•17 years ago
|
||
Isn't that too much of a hack?
Assignee | ||
Comment 5•17 years ago
|
||
Not necessarily, but I think it's too late to do that now.
Comment 6•17 years ago
|
||
Enn, Vlad: are these states part of the textbox object in Vista? Is the right fix here to look into pulling those states forward?
Updated•17 years ago
|
Flags: wanted-firefox3+
Comment 7•17 years ago
|
||
I think the "correct" style for this is actually a background image stored in AB::AddressBand (there's even ABRed, ABYellow, and ABGreen if you really wanted to follow IE). But the images are just rgba(255,255,255,185), rgba(255,255,255,229) and rgba(255,255,255,255) with a little 2px white and black border around them.
Someone did a lot of digging putting names with images in areo.msstyles over at:
http://www.aeroxp.org/wiki/aeromsstyles/
Reporter | ||
Comment 8•16 years ago
|
||
We probably want to land this at the same time as using Aero glass. Added the polish whiteboard terms just for tracking.
Reporter | ||
Comment 9•16 years ago
|
||
Changed my mind on the landing at the same time as Aero glass: I want us to hard code the appearance of the textfield to make it look right for Aero (similar to how we create the location bar field on OS X), using the css selector for when we know the user has the Aero theme.
Assignee | ||
Comment 10•16 years ago
|
||
(In reply to comment #9)
> I want us to
> hard code the appearance of the textfield to make it look right for Aero
> (similar to how we create the location bar field on OS X), using the css
> selector for when we know the user has the Aero theme.
Comment 7 describes the right way to fix this.
Assignee | ||
Updated•16 years ago
|
Component: Theme → Widget: Win32
Flags: wanted-firefox3+
Product: Firefox → Core
QA Contact: theme → win32
Comment 11•16 years ago
|
||
To clarify, this color changing of the text fields applies only to text fields on glass, right?
Also, the link in comment 7 doesn't work.
Assignee | ||
Comment 12•16 years ago
|
||
(In reply to comment #11)
> To clarify, this color changing of the text fields applies only to text fields
> on glass, right?
I think that's MS' idea, but not necessarily what we want to do, since (AFAIK) we're not going to use aero glass for the main window anytime soon.
> Also, the link in comment 7 doesn't work.
http://web.archive.org/web/20071126134023/http://www.aeroxp.org/wiki/aeromsstyles
It says this:
[IMAGE.572.1033]
AB::AddressBand.Background..Image=Image
Query Builder.Background Spray..Image=Image
Reporter | ||
Comment 13•16 years ago
|
||
In the case of windows mail and windows calendar, we see this behavior for the fields when not on glass. However, other fields that are in more of the content area, like the search fields in media player and photo gallery, do not have this effect.
Assignee | ||
Comment 14•16 years ago
|
||
There's also ABComposited::AddressBand and SearchBoxComposited::SearchBox.
Reporter | ||
Comment 15•16 years ago
|
||
This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.
impacts the main window, and a very common control
Whiteboard: [polish-easy][polish-interactive] → [polish-easy][polish-interactive][polish-p1]
Assignee | ||
Comment 16•15 years ago
|
||
This is quite easy to do in the theme with the new location and search bar style.
Component: Widget: Win32 → Theme
OS: Windows Vista → Windows 7
Product: Core → Firefox
QA Contact: win32 → theme
Summary: Vista main window text field hover and selection behavior → Main window text fields should be transparent when using Glass
Assignee | ||
Comment 17•15 years ago
|
||
This uses the alpha values from comment 7.
Updated•15 years ago
|
Attachment #434827 -
Flags: review?(rflint) → review+
Assignee | ||
Comment 18•15 years ago
|
||
Severity: normal → enhancement
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a4
Comment 19•15 years ago
|
||
Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100327 Minefield/3.7a4pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•