Closed
Bug 428591
Opened 17 years ago
Closed 15 years ago
idl is hiding the fact QUERY_TYPE_BOOKMARKS does not support grouping atm
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 3.7a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta1-fixed |
People
(Reporter: cmtalbert, Unassigned)
References
Details
(Keywords: dev-doc-complete)
Attachments
(2 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
The only RESULTS_AS setting that works for Bookmark queries is RESULTS_AS_URI. For everything else, no results are returned in the result set.
I'll attach a test that demonstrates this behavior.
= Expected Behavior =
The results as queries should work for bookmarks too, the RESULTS_AS_DATE* should work if the bookmarks have a visit associated with them, the RESULTS_AS_SITE should always work since bookmarks have URIs associated with them.
= Actual =
Only RESULTS_AS_URI returns any results for a bookmark query.
Updated•16 years ago
|
Comment 1•15 years ago
|
||
this is true, our code actually does not allow grouping bookmarks, the idl does not say anything about that, so i'm going to add notes to the idl, and this should be fixed in future if possible adding support for more complex queries (rewriting the query builder class could make this easier).
Attachment #395828 -
Flags: review?(dietrich)
Comment 2•15 years ago
|
||
(In reply to comment #1)
> this is true, our code actually does not allow grouping bookmarks, the idl does
> not say anything about that, so i'm going to add notes to the idl, and this
> should be fixed in future if possible adding support for more complex queries
> (rewriting the query builder class could make this easier).
please file a bug for this change, and make it block the query-builder-rewrite bug.
Comment 3•15 years ago
|
||
Comment on attachment 395828 [details] [diff] [review]
add idl notes
clear enough, r=me
Attachment #395828 -
Flags: review?(dietrich) → review+
Comment 4•15 years ago
|
||
morphing the bug, this will handle idl comment only, i'll file a separate one for grouping
Summary: RESULTS_AS* not working for queries of type QUERY_TYPE_BOOKMARKS → idl is hiding the fact QUERY_TYPE_BOOKMARKS does not support grouping atm
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Comment 6•15 years ago
|
||
status1.9.2:
--- → beta1-fixed
Updated•15 years ago
|
Keywords: dev-doc-needed
Comment 7•15 years ago
|
||
Updated the docs here:
https://developer.mozilla.org/en/nsINavHistoryQueryOptions#Result_type_constants
Keywords: dev-doc-needed → dev-doc-complete
Comment 8•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•