Save Page As saves "Web Page, Complete" when using the toolkit file picker even when I select "HTML Only". STEPS TO REPRODUCE 1. start Firefox with a clean profile 2. about:config 3. set "ui.allow_platform_file_picker" to false 4. visit any page 5. Save Page As 6. in file picker: enter a file name, select "Web Page, HTML only", Save ACTUAL RESULTS Page is saved as "Web Page, complete". EXPECTED RESULTS A single HTML file with the original page contents please. PLATFORMS AND BUILDS TESTED Bug occurs in Firefox 2008041104 on Linux.

Do you happen to know roughly when this regressed?

Regression window: 2008-02-26-04 -- 2008-02-27-04 http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-02-26+03%3A00&maxdate=2008-02-27+05%3A00&cvsroot=%2Fcvsroot I also noticed that the 2008-02-27-04 build does not remember the last value used for "Web Page, complete"/"Web Page, HTML only" after a restart. 2008-02-26-04 does remember the last selected value, maybe that's got something to do with it...

Bug 412822 seems to be the culprit. Specifically the change from: - var filterMenuList = document.getElementById("filterMenuList"); - retvals.filterIndex = filterMenuList.selectedIndex; to: + retvals.filterIndex = document.getElementById("filterMenuList"); in toolkit/components/filepicker/content/filepicker.js

This fixes it for me.

Comment on attachment 315289 [details] [diff] [review] Patch rev. 1 hrm, sorry. i wonder if that was a merge conflict.

Comment on attachment 315289 [details] [diff] [review] Patch rev. 1 Zero risk (typo).

mozilla/toolkit/components/filepicker/content/filepicker.js 1.21 -> FIXED