Wanted by bug 360488. *** I had a look at the current TB and SM code: it seems porting the TB patch from bug 373270 either needs some previous patches or the code has changed since then. It might be easier to synchronize SM and TB here, before looking into bug 324953.

Let's start with a TB->SM "whitespace" synchronization. Use Av1-SM-Bw to ease review.

Trivial SM->TB "whitespace" synchronization (feedback).

Comment on attachment 315319 [details] [diff] [review] (Bv1-TB) <mailCommands.js> I don't actually have review privs for mail/. Passing to someone who does ;-)

Comment on attachment 315317 [details] [diff] [review] (Av1-SM) <mailCommands.js> I generally don't think that mere whitespace changes are valuable by itself, so: >Index: mailCommands.js >=================================================================== > var messageURI = aMsgHdr.folder.generateMessageURI(aMsgHdr.messageKey) >- + "?fetchCompleteMessage=true"; >+ + "?fetchCompleteMessage=true"; This is not quite right, = and + should be aligned. r=me with that change, but only if the TB patch is accepted as well and only as a precondition to ease fixing bug 324953.

Comment on attachment 315319 [details] [diff] [review] (Bv1-TB) <mailCommands.js> >+ var messageURI = aMsgHdr.folder.generateMessageURI(aMsgHdr.messageKey) >+ + "?fetchCompleteMessage=true"; To quote http://beaufour.dk/jst-review/?patch=315319, "Operators should be at the end of the line, not the beginning." I also really very strongly think that you should rethink your approach to porting patches: this "before I can even start doing anything, I have to sync all the whitespace between two different projects" approach is not a good one.

Bv1-TB, with comment 6 suggestion(s); actually, that line has been removed in the meantime ... and others added. *** (I know ... Yet, it does help (me) to find the actual differences...)

Av1-SM, with comment 5 (-> actually, comment 6) suggestion(s), plus updated sync' to current trunk.

Comment on attachment 324785 [details] [diff] [review] (Av2-SM) <mailCommands.js> This patch does nothing to solve the issue of bug 373270. It just removes some whitespace and braces and doesn't touch any misaligned braces still there. It's all good and well to fix such nuisances, but this doesn't help fixing any actual bug. Minussing for uselessness alone. It's much more worthwhile to go hunting down real deer! ;-)

Comment on attachment 324784 [details] [diff] [review] (Bv2-TB) <mailCommands.js> Your first step in fixing these bugs is to diff the copy of the Thunderbird file and the copy of the SeaMonkey file in your tree, figure out which differences are just whitespace and trivialities, and change the file in your tree that has it wrong, correct? Then you create a patch (or two patches) of just that, and wait for review, and wait for it (or them) to be checked in, and then you update your tree, and again diff the copy of the Thunderbird file and the copy of the SeaMonkey file in your tree, and then begin on the actual work, right? What would be the difference in your workflow if instead you made the whitespace changes, saved a diff of the SeaMonkey file so you could remember what changes you made just for prettification, and then immediately proceeded to do the actual work, diffing against your modified Thunderbird file instead of your modified Thunderbird file after it had been reviewed and checked in and updated in your tree? I don't see any difference. Sorry, but as you might have guessed by all the trouble you have getting review for your whitespace changes to Thunderbird, we really aren't interested in cluttering our CVS blame and history with lots of sync-the-whitespace changes. If you happen to be writing actual patches to Thunderbird, and notice an error in a nearby line, then please do fix it, but, please find another way to port Thunderbird patches to SeaMonkey, one which does not involve having to land whitespace-syncing.

I believe this has now been fixed with the patch to bug 324953.

This bug is open but targeted for seamonkey2.0a1, which has been released a long time ago. Please set the target milestone to an appropriate value, "---" if it has no specific target.

Fixed by unforking in Bug 324953