Closed Bug 428817 Opened 17 years ago Closed 17 years ago

Dropmarker and arrows on all-tabs and tab overflow buttons are slightly misaligned in Windows

Categories

(Firefox :: Theme, defect)

x86
Windows XP
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 3

People

(Reporter: kliu, Assigned: kliu)

References

Details

(Keywords: polish)

Attachments

(2 files)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041206 Minefield/3.0pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041206 Minefield/3.0pre Dropmarker and arrows on all-tabs and tab overflow buttons are slightly misaligned in Windows. Specifically, the dropmarker on the all-tabs button is not horizontally centered (7 pixel gap on the left, 5 pixel gap on the right), and the arrows on the tab overflow buttons and dropmarker on the all-tabs button are not vertically centered with respect to the text and icons on the tabs in the tab strip. See the screenshot in comment 1 for details. Reproducible: Always Steps to Reproduce: 1. Launch Minefield 2. Zoom in and do some pixel counting. :)
Attached patch patch (deleted) — Splinter Review
Shift the dropmarker left by one pixel to address horizontal misalignment. Shift arrows and dropmarker up by one pixel to address vertical misalignment.
Attachment #315391 - Flags: ui-review?(faaborg)
Attachment #315391 - Flags: review?(gavin.sharp)
Keywords: polish
Version: unspecified → Trunk
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 315391 [details] [diff] [review] patch Thanks for the descriptive screenshot, that really helps!
Attachment #315391 - Flags: review?(gavin.sharp) → review+
Assignee: nobody → kliu.bugzilla.3c9f
Comment on attachment 315391 [details] [diff] [review] patch You could also consider moving the arrows up by 2 pixels. Since the arrows are an odd number of pixels tall in an even height area, it will be impossible to vertically center them perfectly. You should choose if you think moving them up 1 or 2 pixels looks better.
Attachment #315391 - Flags: ui-review?(faaborg) → ui-review+
Comment on attachment 315391 [details] [diff] [review] patch (In reply to comment #4) I think I'll stick with 1px. The visual weight of the dropmarker is such that it looks a liiiiiiiitle better with the 1px shift than with a 2px shift.
Attachment #315391 - Flags: approval1.9?
Flags: blocking-firefox3?
Comment on attachment 315391 [details] [diff] [review] patch a1.9=beltzner
Attachment #315391 - Flags: approval1.9? → approval1.9+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Flags: blocking-firefox3? → blocking-firefox3+
mozilla/browser/themes/winstripe/browser/browser.css 1.202
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
Blocks: 429979
No longer blocks: 429979
Depends on: 429979
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: