Bug 392446 should have been WONTFIX but got fixed by bug 408565, which had the inadvertant effect of actually leading to error dialogs when the menuItem is used on Windows (see bug 392446 comment 10) We should disable that menuItem, undoing the inadvertent fix of bug 408565. Doesn't block.

So, should 'show in finder' be gray for in-progress downloads? The problem with allowing that is that the final file doesn't actually exist yet (might be downloading to a temporary file), and that would probably lead to the same error message on windows for bug 392446.

Oh wait, perhaps not. Openable is being checked.

Comment on attachment 315799 [details] [diff] [review] v1 let's just add a new case statement for this please

I was going to but remembered something strange happening with lets in switch. Do I need to put a block around the cmd_open case as well as the cmd_show case?

Put the lets inside blocks.

Comment on attachment 315803 [details] [diff] [review] v1.1 yeah, this is what I want. r=sdwilsh

Comment on attachment 315803 [details] [diff] [review] v1.1 a1.9=beltzner

Checking in toolkit/mozapps/downloads/content/downloads.js; /cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v <-- downloads.js new revision: 1.147; previous revision: 1.146 done Checking in toolkit/mozapps/downloads/tests/browser/browser_multi_select.js; /cvsroot/mozilla/toolkit/mozapps/downloads/tests/browser/browser_multi_select.js,v <-- browser_multi_select.js new revision: 1.2; previous revision: 1.1 done

in-litmus+; I amended https://litmus.mozilla.org/show_test.cgi?id=5257 to reflect this change.

Verified FIXED using: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008041604 Minefield/3.0pre Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008041604 Minefield/3.0pre -and- Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008041606 Minefield/3.0pre When a downloaded file is deleted on disk or moved, we disable Open and Open Containing Folder / Show in Finder context-menu items.