Closed Bug 42916 Opened 24 years ago Closed 24 years ago

[ssl] Trying to add CA/server cert from web page crashes mozilla if PSM is not installed

Categories

(Core Graveyard :: Security: UI, defect, P3)

1.0 Branch
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: david, Assigned: ddrinan0264)

References

()

Details

(Whiteboard: [nsbeta3+][nsbeta2-])

BuildID: M16 Trying to add a CA from a page (one can be found at the example URL by clicking the "win"-icon) will crash mozilla (with an error in psmglue.dll) if PSM is not installed. This is somewhat related to bug #20503 Reproducible: Always Steps to Reproduce: 1. Go to URL above 2. Click "win"-icon 3. See mozilla crash Actual Results: Mozilla crashed Expected Results: Mozilla should complain about PSM not being installed Does other unknown filetypes also crash moz?
Linux, build ID 2000061708 crashes. Windows 95, build ID 2000061708 crashes: Translated from Dutch: MOZILLA has caused an invalid page exception in module PSMGLUE.DLL at 0137:606c9693. Registers: EAX=0068f974 CS=0137 EIP=606c9693 EFLGS=00010246 EBX=00000000 SS=013f ESP=0068f950 EBP=0068f980 ECX=00000000 DS=013f ESI=00000000 FS=4367 EDX=00000001 ES=013f EDI=00000000 GS=0000 Bytes in CS:EIP: 8b 46 2c 85 c0 74 06 ff 30 ff 50 04 59 8b 7c 24 Stack-dump: 00000000 00000000 606c8d7e 00000000 0068f974 00000001 007b45f4 01ca96d0 000002e5 10004a00 01ca93d0 000002f0 0068f9ac 606c2246 00000000 01ca96d0 Confirming bug, suspecting this is cross platform.
Status: UNCONFIRMED → NEW
Ever confirmed: true
over to jud.
Assignee: dougt → valeski
Adding crash keyword
Keywords: crash
Reproducible on WinNT in mozilla.exe.
OS: Windows 98 → All
Hardware: PC → All
Target Milestone: --- → M17
Fixed. I can import the CA into Linux and Win32.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verified.
Status: RESOLVED → VERIFIED
It still doesnt work for me, please note that the bug is when you try to import a cert when PSM isn't installed, judging from "I can import the CA into Linux and Win32." I'm wondering if you have PSM installed? With Win build 2000062608 Mozilla first hangs and when I kill it (with ctrl+alt+del) it gives me the following message: PSM has caused an invalid page exception in module NSPR3.DLL at 0167:005c04e5. Registers: EAX=00000000 CS=0167 EIP=005c04e5 EFLGS=00010246 EBX=0081fd20 SS=016f ESP=0081fccc EBP=0081fe38 ECX=0081fe28 DS=016f ESI=00000000 FS=2317 EDX=00000004 ES=016f EDI=00993960 GS=0000 Bytes in CS:EIP: 8b 46 04 8b 08 51 e8 70 07 00 00 83 c4 04 8b 4e Stackdump: 00993960 0040370f 00000000 00000000 004029ed 00402582 00993960 00000001 ffffffff 00993960 004030c7 00993960 00000000 00993610 00710000 004024c3
Right. Reopening. The crash is reproducible if PSM is not installed.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Adding nsbeta2 keyword
Keywords: nsbeta2
Putting on [nsbeta2+] radar to stop the crash.
Whiteboard: [nsbeta2+]
Reassigning to Browser:General. Security:Crypto cannot be blamed for a crash in Mozilla if it is not installed. The original summary reads "Trying to add CA/server cert from web page crashes mozilla IF PSM IS NOT INSTALLED."
Assignee: valeski → clayton
Status: REOPENED → NEW
Component: Security: Crypto → Browser-General
Stack trace for segfault (on Linux): #0 0x421e1f1f in CMT_SendMessage (control=0x0, message=0xbffff520) at /builds/dbaron/debug/mozilla/security/psm/lib/client/cmtutils.c:295 #1 0x421e28da in CMT_DecodeAndCreateTempCert (control=0x0, data=0x42d17608 "0\202\002á0\202\002J\002\001", len=741, type=1) at /builds/dbaron/debug/mozilla/security/psm/lib/client/cmtcert.c:75 #2 0x4231d6b7 in CertDownloader::OnStopRequest (this=0x42ba9440, channel=0x42ba8fa8, context=0x42b58d60, aStatus=0, aMsg=0x0) at /builds/dbaron/debug/mozilla/extensions/psm-glue/src/nsPSMComponent.cpp:675 #3 0x40e63596 in nsHTTPFinalListener::OnStopRequest (this=0x42ba9460, aChannel=0x42ba8fa8, aContext=0x42b58d60, aStatus=0, aErrorMsg=0x0) at /builds/dbaron/debug/mozilla/netwerk/protocol/http/src/nsHTTPResponseListener.cpp:1195 #4 0x421b0116 in InterceptStreamListener::OnStopRequest (this=0x428f2950, channel=0x42ba8fa8, ctxt=0x42b58d60, status=0, errorMsg=0x0) at /builds/dbaron/debug/mozilla/netwerk/cache/mgr/nsCachedNetData.cpp:1161 #5 0x40e58741 in nsHTTPChannel::ResponseCompleted (this=0x42ba8fa8, aListener=0x428f2950, aStatus=0, aMsg=0x0) at /builds/dbaron/debug/mozilla/netwerk/protocol/http/src/nsHTTPChannel.cpp:1700 #6 0x40e622f1 in nsHTTPServerListener::OnStopRequest (this=0x42d37cd0, channel=0x428f3a04, i_pContext=0x42ba8fa8, i_Status=0, i_pMsg=0x0) at /builds/dbaron/debug/mozilla/netwerk/protocol/http/src/nsHTTPResponseListener.cpp:721 #7 0x40dfaeb8 in nsOnStopRequestEvent::HandleEvent (this=0x80e9a78) at /builds/dbaron/debug/mozilla/netwerk/base/src/nsAsyncStreamListener.cpp:313 #8 0x40dfa497 in nsStreamListenerEvent::HandlePLEvent (aEvent=0x80e6308) at /builds/dbaron/debug/mozilla/netwerk/base/src/nsAsyncStreamListener.cpp:101 #9 0x401163fe in PL_HandleEvent (self=0x80e6308) at /builds/dbaron/debug/mozilla/xpcom/threads/plevent.c:575 #10 0x401162ac in PL_ProcessPendingEvents (self=0x8066b28) at /builds/dbaron/debug/mozilla/xpcom/threads/plevent.c:520 #11 0x40118039 in nsEventQueueImpl::ProcessPendingEvents (this=0x8066a70) at /builds/dbaron/debug/mozilla/xpcom/threads/nsEventQueue.cpp:356 #12 0x40a755e4 in event_processor_callback (data=0x8066a70, source=9, condition=GDK_INPUT_READ) at /builds/dbaron/debug/mozilla/widget/src/gtk/nsAppShell.cpp:158 #13 0x40a7521f in our_gdk_io_invoke (source=0x41e41570, condition=G_IO_IN, data=0x41edafd8) at /builds/dbaron/debug/mozilla/widget/src/gtk/nsAppShell.cpp:58 #14 0x40c4052a in ?? () from /usr/lib/libglib-1.2.so.0 #15 0x40c41be6 in ?? () from /usr/lib/libglib-1.2.so.0 #16 0x40c421a1 in ?? () from /usr/lib/libglib-1.2.so.0 #17 0x40c42341 in ?? () from /usr/lib/libglib-1.2.so.0 #18 0x40b69209 in ?? () from /usr/lib/libgtk-1.2.so.0 #19 0x40a75cda in nsAppShell::Run (this=0x810a648) at /builds/dbaron/debug/mozilla/widget/src/gtk/nsAppShell.cpp:334 #20 0x40729a54 in nsAppShellService::Run (this=0x810bdf8) at /builds/dbaron/debug/mozilla/xpfe/appshell/src/nsAppShellService.cpp:386 #21 0x8053c55 in main1 (argc=1, argv=0xbffffb04, nativeApp=0x0) at /builds/dbaron/debug/mozilla/xpfe/bootstrap/nsAppRunner.cpp:913 #22 0x805433e in main (argc=1, argv=0xbffffb04) at /builds/dbaron/debug/mozilla/xpfe/bootstrap/nsAppRunner.cpp:1099
control is null, and nobody's checking whether it's null. Who gets this bug?
Removing nsbeta2+ for reconsideration. This happens when PSM is not installed. It is always installed for Netscape commercial builds, therefore, I don't think that we need to fix this before we ship pr2.
Whiteboard: [nsbeta2+]
Pierre, can you please triage.
Assignee: clayton → pierre
Putting on [nsbeta2-] radar. Not critical to beta2.
Whiteboard: [nsbeta2-]
(Why was this bug sent to Browser-General?) We have the same stack trace on the Mac as on Unix (I had to use an old Mac build to reproduce the crash because of bug 44627 that would have hidden it). The crash occurs in CMT_DecodeAndCreateTempCert(). Changed Component to Security- General. CCd mstoltz who is module owner. Reassigned to dougt who wrote the code.
Assignee: pierre → dougt
Component: Browser-General → Security: General
Module should be security:crypto, as with all PSM issues.
Component: Security: General → Security: Crypto
.
Assignee: dougt → valeski
Assigning to ddrinan
Assignee: valeski → ddrinan
Keywords: nsbeta2nsbeta3
Target Milestone: M17 → M18
Adding nsbeta2 keyword to bugs with nsbeta2 triage value in status field so the queries don't get screwed up
Keywords: nsbeta2
Blocks: 48444
Setting status whiteboard to nsbeta3+.
Whiteboard: [nsbeta2-] → [nsbeta3+]
PR2 is out...adding [nsbeta2-] Already has [nsbeta3+]
Whiteboard: [nsbeta3+] → [nsbeta3+][nsbeta2-]
With the netscape6 build of 20000829 for linux without psm when I try to access a server which will bring up the server cert it does not crash netscape6.
Fixed.
Fixed.
Status: NEW → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
Verifying this depends on Mac bug 50931 - Security Pop-up windows are blank. This works on Win95 and Linux using PSM 1.3 9/5/2000. Removing crash keyword.
Depends on: 50931
Keywords: crash
Verified with the 9/18 091908 Moz build.
Status: RESOLVED → VERIFIED
Mass changing Security:Crypto to PSM
Component: Security: Crypto → Client Library
Product: Browser → PSM
Target Milestone: M18 → ---
Version: other → 2.1
Mass changing Security:Crypto to PSM
Product: PSM → Core
Version: psm2.1 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.