Closed Bug 429310 Opened 17 years ago Closed 15 years ago

Change moz-appearance of autocomplete-history-dropmarker to menulist-button for Vista

Categories

(Firefox :: Theme, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: andrewm715+bugzilla, Unassigned)

References

Details

(Keywords: polish)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008040404 Firefox/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008040404 Firefox/3.0pre

Spinoff from bug 406894.

Lim Chee Aun posted the following code in bug 406894 comment 19 which can be added to userChrome.css to change the autocomplete-history-dropmarker on Vista to menulist-button:

#urlbar > .autocomplete-history-dropmarker{
-moz-appearance: menulist-button !important;
margin: -1px -1px -1px 0 !important;
}

The result can be seen in attachment 313893 [details].

In bug 408694 comment 24, Mike Beltzner said: "Can we get a separate bug on that filed with that patch nominated for review
and approval? That looks a lot nicer for Vista than what we have now.
", so here is the bug :)

I have only noticed one small problem with using this, which is that on secure sites, the background of the dropdown arrow button stays white while the rest of the location bar turns yellow. This would be a moot point if it is decided not to turn the location bar yellow on Windows, of course.

Reproducible: Always
(In reply to comment #0)
> ...
> In bug 408694 comment 24, Mike Beltzner said: "Can we get a separate bug on
> that filed with that patch nominated for review
> and approval? That looks a lot nicer for Vista than what we have now.
> ", so here is the bug :)

Oops, that should of course be bug 406894 comment 24.
Blocks: 405605, 406894
Keywords: polish
Version: unspecified → Trunk
If margin is changed to 0 instead of -1px, this would also be a nice change on XP.
Once bug 428878 lands, this would be great to have for Classic, too.  But without the -1px margins, of course.
Status: UNCONFIRMED → NEW
Component: Location Bar and Autocomplete → Theme
Depends on: 417844
Ever confirmed: true
QA Contact: location.bar → theme
Bug 430434 eliminates the hover state of the dropmarker in chrome.  While that bug was intended to be applied only to menulists that are shaped like a button, it also means that the dropmarker can't be used in this case, where it's shaped like a text box.  Could 430434 be implemented differently to avoid using the chrome-vs-content distinction as a proxy for the button-vs-textbox distinction?
Depends on: 431078
No longer blocks: 406894
I think attachment 313893 [details] looks unbalanced with the two different dropmarkers next to each other.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.