Perl is too smart for its own good. Best shown by example: [root@mradm02 bugzilla.mozilla.org]# perl testpwd.pl pwd = /data/php5/www/bugzilla.mozilla.org system('ls','-l','graphs'); lrwxrwxrwx 1 root root 39 Jan 15 00:06 graphs -> /mnt/netapp/bugzilla.mozilla.org/graphs chdir graphs pwd = /mnt/netapp/bugzilla.mozilla.org/graphs chdir .. pwd = /mnt/netapp/bugzilla.mozilla.org This causes collectstats.pl to fail with: '' is not a valid choice for $db_driver in localconfig: Null filename used at (eval 30) line 2. because when it gets to the point of loading localconfig, it can't find it because the working directory is wrong. Instead of doing a chdir('..') we need to do a GetPwd first then chdir back to the full path isntead of to ..

This adds a |use Cwd;|, but the Cwd module is part of the PathTools package, which we already require (and already make use of in checksetup.pl as well).

Patch applies cleanly on both 3.0 and trunk.

Comment on attachment 316095 [details] [diff] [review] Patch v1 That looks fine to me, at least.

It might be nice to have a concurrence from glob that this won't break on Windows or anything strange like that.

trunk: Checking in collectstats.pl; /cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v <-- collectstats.pl new revision: 1.64; previous revision: 1.63 done 3.0 branch: Checking in collectstats.pl; /cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v <-- collectstats.pl new revision: 1.58.2.4; previous revision: 1.58.2.3 done

(In reply to comment #4) > It might be nice to have a concurrence from glob that this won't break on > Windows or anything strange like that. looks fine to me.