Andrés Delfino Reporter
	Description • 17 years ago

User-Agent:       Mozilla/5.0 (X11; U; OpenBSD i386; en-US; rv:1.8.1.6) Gecko/20070819 Firefox/2.0.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041606 Minefield/3.0pre

Non-native separator between toolbars and content area. In Windows Classic, the content area should look like a giant text box, since it's "keeping something inside", so their borders should be the same.

I attach screenshots of current style, and expected native style.

Reproducible: Always

	Simon Bünzli
	Comment 3 • 17 years ago

The content area is intentionally not sunken as this would require a 2px border around it which is anti-Fitts'y (i.e. when the window is maximized, the scrollbar doesn't extend to the screen margin, nor does the left side of the webpage).

One option would be to make the content area sunken for non-maximized windows and remove the unwanted right/left border for maximized windows (note that in your second screenshot the corresponding bottom border is still missing!). Since we've got this since the start of Firefox, there's surely a DUPE for this request, though...

	Andrés Delfino Reporter
	Comment 4 • 17 years ago

Note that two lines separate the toolbars and the content area, and two other lines separate the content area and the status bar.

	Andrés Delfino Reporter
	Comment 5 • 17 years ago

(In reply to comment #3)
> The content area is intentionally not sunken as this would require a 2px border
> around it which is anti-Fitts'y (i.e. when the window is maximized, the
> scrollbar doesn't extend to the screen margin, nor does the left side of the
> webpage).

Please note that I am not requesting to add left and right borders. I only suggest some horizontal lines, which would look more native than what it is shown right now.

The behavior of the scrollbars wouldn't be affected at all.

	Simon Bünzli
	Comment 6 • 17 years ago

(In reply to comment #5)
> Please note that I am not requesting to add left and right borders.

And you only request them for Windows Classic, although they should also exist in Luna. Looks like you're getting somewhat sloppy, Andrés? ;-)

	Andrés Delfino Reporter
	Comment 7 • 17 years ago

(In reply to comment #6)
> (In reply to comment #5)
> > Please note that I am not requesting to add left and right borders.

The current approach is less native, and feels out of place. Even we don't use real sunken, it's still better to have good the correct style for the borders that we do show.

> And you only request them for Windows Classic, although they should also exist
> in Luna. Looks like you're getting somewhat sloppy, Andrés? ;-)

Sorry :P Since I don't use Luna regularly, I forgot to check.

I'll update this bug for Luna later this day, attaching a screenshot.

	Kai Liu
	Comment 8 • 17 years ago

Should be simple enough.  Add a 1px top border to all the xul:browser elements (we shouldn't do this in the toolbox because we may have the tab strip showing up between the content area and the toolbox)... unless we want that sunken feel for the boundary between the toolbox and the tabstrip, too.

I'm so tempted to just file a omnibus "Polish up the Classic look" bug because there are so many of these trivial bugs, and each one would require separate reviews, checkins, etc. and the overhead far exceeds the trivial patches needed.  But, yes, yes, I know that big rollup bugs are frowned upon...

	Simon Bünzli
	Comment 9 • 17 years ago

Just do yourself the favor to ask for ui-review before investing significant time in this issue, as I remember having seen this WONTFIXed a few years ago.

	Simon Bünzli
	Comment 10 • 16 years ago

(In reply to comment #8)
> I'm so tempted to just file a omnibus "Polish up the Classic look" bug because
> there are so many of these trivial bugs

What would actually help is a "Windows Classic Polish" tracker/meta bug: File a new bug, give it the keyword "meta" and mark all bugs such as this one as blocking your new tracker (cf. e.g. bug 333484 or bug 425582).

	(no longer active)
	Comment 11 • 16 years ago

Comment on attachment 316316 [details]
Expected more native style.

Let's see what's Beltzner's take on this.

	Dão Gottwald [:dao]
	Comment 12 • 16 years ago

IE draws a border *within* the content area, which you can actually remove with CSS. There's nothing native about that.