Closed
Bug 429666
Opened 17 years ago
Closed 17 years ago
Expose ROLE_DOCUMENT for ARIA landmarks that inherit from document
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
VERIFIED
FIXED
mozilla1.9.1a1
People
(Reporter: aaronlev, Assigned: aaronlev)
References
(Blocks 1 open bug)
Details
(Keywords: access, Whiteboard: post1.9[has-patch,has-review])
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
MarcoZ
:
review+
damons
:
approval1.9-
|
Details | Diff | Splinter Review |
(deleted),
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
At least 1 ARIA landmark inherits from "document" -- it's role="article".
For the ATK/MSAA enumerated roles we are supposed to expose the closest role. In this case that would be ROLE_DOCUMENT.
I'll have to check to see if there are other sitatuons like this.
Assignee | ||
Comment 1•17 years ago
|
||
There are no other descendant roles for document.
Attachment #316809 -
Flags: review?(marco.zehe)
Comment 2•17 years ago
|
||
Comment on attachment 316809 [details] [diff] [review]
Support article with ROLE_DOCUMENT
r=me
Attachment #316809 -
Flags: review?(marco.zehe) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #316809 -
Flags: approval1.9?
Comment 3•17 years ago
|
||
Comment on attachment 316809 [details] [diff] [review]
Support article with ROLE_DOCUMENT
Tests? Explanation of risk? Re-request approval once addressed.
Attachment #316809 -
Flags: approval1.9? → approval1.9-
Assignee | ||
Updated•17 years ago
|
Whiteboard: post1.9
Updated•17 years ago
|
Whiteboard: post1.9 → post1.9[has-patch,has-review]
Comment 4•17 years ago
|
||
Aaron, is there a test page I could use for a Mochitest for this one?
Assignee | ||
Comment 5•17 years ago
|
||
Comment 6•17 years ago
|
||
Original patch by Aaron, this also contains a Mochitest for it.
Attachment #324597 -
Attachment is obsolete: true
Attachment #325233 -
Flags: review?(surkov.alexander)
Comment 7•17 years ago
|
||
Comment on attachment 325233 [details] [diff] [review]
Patch containing both original patch and Mochitest
r=me.
Though I would suggest to call the file as "test_aria_role_article". We have already the file (test_aria_activedescendant). It should be easier to find out that file and extend test in the future.
Attachment #325233 -
Flags: review?(surkov.alexander) → review+
Comment 8•17 years ago
|
||
Pushed in changeset:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/cc03e7e0747b
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment 9•17 years ago
|
||
Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1pre) Gecko/2008062603 Minefield/3.1a1pre
Status: RESOLVED → VERIFIED
Updated•16 years ago
|
Target Milestone: --- → mozilla1.9.1a1
You need to log in
before you can comment on or make changes to this bug.
Description
•