Closed Bug 430259 Opened 17 years ago Closed 16 years ago

Location bar auto-complete results box has no bottom border

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.6a1

People

(Reporter: adelfino, Assigned: ventnor.bugzilla)

References

Details

(Keywords: polish, regression, verified1.9.1, Whiteboard: [polish-easy] [polish-visual][polish-p1])

Attachments

(2 files)

Screenshot.
(deleted), image/png
Details
Patch [Checkin: Comment 13]
(deleted), patch
rflint
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008042205 Minefield/3.0pre Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008042205 Minefield/3.0pre Location bar auto-complete results box has no bottom border. Please see screenshot. Reproducible: Always
Attached image Screenshot. (deleted) —
Version: unspecified → Trunk
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008042204 Minefield/3.0pre Can confirm!!! :)
Status: UNCONFIRMED → NEW
Ever confirmed: true
That's a regression from bug 409974. What distribution/Gtk version/Theme are you using? I could saw the issue on Ubuntu Gutsy with default theme, but this is looking fine on this computer running Hardy and compiz.
Keywords: regression
(In reply to comment #3) > That's a regression from bug 409974. What distribution/Gtk version/Theme are > you using? Ubuntu Gutsy, with Glossy theme.
Keywords: polish
Whiteboard: [polish-easy] [polish-visual]
This bug appears when in gtk theme for menus x/ythikness are zero, I think
Alex - what do you want this to look like?
Whiteboard: [polish-easy] [polish-visual] → [polish-easy] [polish-visual] [needs ux definition]
There should be a single pixel border line, which continues on across the bottom, and is not obfuscated by the lines between results.
Whiteboard: [polish-easy] [polish-visual] [needs ux definition] → [polish-easy] [polish-visual]
Bug 429857 might fix this for free, if it ends up that we're drawing the last-item border directly on top of the results box border (ie, it's already there but is just hidden)
Depends on: 429857
This works for me on both the stock Ubuntu FF3.0.4 and my FF3.1 debug build. Fixed, or needs more steps to reproduce?
That depends on the selected Gtk theme. With Human, I can see the issue on 3.0.4 but it is fixed on trunk. With Clearlooks, I see the issue on both versions.
Attached patch Patch [Checkin: Comment 13] (deleted) — — Splinter Review
Also fixes bug 430257.
Assignee: nobody → ventnor.bugzilla
Attachment #351267 - Flags: review?(rflint)
Heh. I commented on bug 430257 a whole 6 seconds before you. :) Adding the margin fixes this problem, but means the spacing will be off in other cases... This might be the lesser of two evils, though.
Attachment #351267 - Flags: review?(rflint) → review+
Keywords: checkin-needed
Blocks: 430257
Comment on attachment 351267 [details] [diff] [review] Patch [Checkin: Comment 13] http://hg.mozilla.org/mozilla-central/rev/8ceeb8f5d1f2
Attachment #351267 - Attachment description: Patch → Patch [Checkin: Comment 13]
Blocks: 409974
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
Attachment #351267 - Flags: approval1.9.1?
Comment on attachment 351267 [details] [diff] [review] Patch [Checkin: Comment 13] a191=beltzner
Attachment #351267 - Flags: approval1.9.1? → approval1.9.1+
Keywords: checkin-needed
Verified using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3
Status: RESOLVED → VERIFIED
This bug's priority relative to the set of other polish bugs is: P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day. awesome bar results is a primary UI
Whiteboard: [polish-easy] [polish-visual] → [polish-easy] [polish-visual][polish-p1]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: