Spinning off from bug 425998 to be specific to Mac OS X. There's currently no calendar icon in the tree for OS X ... I need confirmation on the intended design. 1. leave as is (shows as folder) 2. land and use a calendar icon as for other OS's in Bug 425998 - or - 3. use the same icon as for history in Places Library (shows as clock face) which would also be similar to styling in the Finder sidebar (which uses a clock face for today, yesterday, past week)

Requesting blocking-firefox3 to get wanted-firefox3, same as Bug 425998

Sorry, the Calendar icon fell off my radar. I will get one ASAP.

Wanted granted, but agree that it's not blocking. Target of opportunity. AIUI, as soon as we have an icon, the hookup is easy.

>Sorry, the Calendar icon fell off my radar. I will get one ASAP. Sorry about that, it was mistakenly marked as not needed on the inventory.

These are the changes corresponding to what was done for other platforms and they look right on the surface. Still, I can't yet build for the Mac, so if someone else wants to take this and finish it up for OS X that would be great. I'm not sure under what conditions the browser.css rule would apply -- possibly with a user-defined query? -- but the selector was already there so now it uses the right icon. Depends on places/calendar.png.

I applied the patch and the icon and it works in my build.

Slight update to mcdavis' patch including jar.mn changes for the new icon.

New Calendar Icon

Comment on attachment 317752 [details] pinstripe browser.css and places.css v2 re-request approval once ui review has been completed.

Comment on attachment 317752 [details] pinstripe browser.css and places.css v2 nit: I think that while we're using calendars on the other platforms, the OSX convention is to use the clock icon here. The patch is sound, but just s/calendar.png/whatever-the-clock-icon-is-called.png/ :)

Changed to Clock for platform and internal consistency. I will update the patch shortly.

Updated patch changing to history.png. Removed the calendar.png sections as they have moved to bug 429725. Does it need another review?

Comment on attachment 318446 [details] [diff] [review] pinstripe browser.css and places.css v3 a1.9=beltzner

Checked in on 2008-05-05 mozilla/browser/themes/pinstripe/browser/browser.css 1.152 mozilla/browser/themes/pinstripe/browser/places/places.css 1.27

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008051009 Minefield/3.0pre ID:2008051009