Closed
Bug 430908
Opened 17 years ago
Closed 17 years ago
Land new windows toolbar icons (2008-04-28)
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3
People
(Reporter: faaborg, Assigned: faaborg)
References
Details
Attachments
(3 files)
(deleted),
application/x-zip-compressed
|
beltzner
:
review+
beltzner
:
ui-review+
beltzner
:
approval1.9+
|
Details |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details |
This bug will track landing what will hopefully be the final drop of windows icons before RC1.
Flags: blocking-firefox3?
Assignee | ||
Comment 1•17 years ago
|
||
These icons should be ready this evening.
Summary: Land new windows icons (2008-04-26) → Land new windows icons (2008-04-27)
Updated•17 years ago
|
Summary: Land new windows icons (2008-04-27) → Land new windows icons (2008-04-28)
Assignee | ||
Comment 3•17 years ago
|
||
Yeah, emphasize on "should be" we have all of the files, I am working on preparing the drop now.
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → faaborg
Status: ASSIGNED → NEW
Comment 4•17 years ago
|
||
This is blocking since it fixes a blocker in that the back/forward dropmarker is always showing as enabled.
Alex: can we get those images checked in immediately and then we can remove this from the blocker list? Unless there are other changes coming in this drop that you believe should block us. I don't really know if I have a full understanding of what this is changing.
Assignee | ||
Comment 5•17 years ago
|
||
Landing these 4 files will clear the blocking flag, but we should leave the bug open for the full drop.
Updated•17 years ago
|
Attachment #318317 -
Flags: approval1.9?
Comment 6•17 years ago
|
||
Comment on attachment 318317 [details]
New Toolbar files
r+uir+a=beltzner
Attachment #318317 -
Flags: ui-review+
Attachment #318317 -
Flags: review+
Attachment #318317 -
Flags: approval1.9?
Attachment #318317 -
Flags: approval1.9+
Comment 7•17 years ago
|
||
Comment on attachment 318317 [details]
New Toolbar files
Checking in browser/themes/winstripe/browser/Toolbar-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-aero.png,v <-- Toolbar-aero.png
new revision: 1.8; previous revision: 1.7
done
Checking in browser/themes/winstripe/browser/Toolbar-small-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small-aero.png,v <-- Toolbar-small-aero.png
new revision: 1.5; previous revision: 1.4
done
Checking in browser/themes/winstripe/browser/Toolbar-small.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small.png,v <-- Toolbar-small.png
new revision: 1.13; previous revision: 1.12
done
Checking in browser/themes/winstripe/browser/Toolbar.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar.png,v <-- Toolbar.png
new revision: 1.14; previous revision: 1.13
done
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 3
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Summary: Land new windows icons (2008-04-28) → Land new windows toolbar icons (2008-04-28)
Target Milestone: Firefox 3 → ---
Comment 8•17 years ago
|
||
(In reply to comment #5)
> Landing these 4 files will clear the blocking flag, but we should leave the bug
> open for the full drop.
Filed 431285 for the remainder.
Comment 9•17 years ago
|
||
rtl xp small icons were shifted 1px left
xp small
4-25: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/87893472b320/browser/themes/winstripe/browser/Toolbar-small.png
4-28: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/878eb6749f48/browser/themes/winstripe/browser/Toolbar-small.png
(open both in tabs and switch between the two)
And if you wanted to just double check the rest..
aero small
4-25: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/87893472b320/browser/themes/winstripe/browser/Toolbar-small-aero.png
4-28: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/878eb6749f48/browser/themes/winstripe/browser/Toolbar-small-aero.png
xp
4-25: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/87893472b320/browser/themes/winstripe/browser/Toolbar.png
4-28: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/878eb6749f48/browser/themes/winstripe/browser/Toolbar.png
aero
4-25: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/87893472b320/browser/themes/winstripe/browser/Toolbar-aero.png
4-28: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/878eb6749f48/browser/themes/winstripe/browser/Toolbar-aero.png
Assignee | ||
Comment 10•17 years ago
|
||
A the disabled keyhole state was 1 pixel off in the last set of attachments, please land this update immediately.
Assignee | ||
Comment 11•17 years ago
|
||
Reopening to land updated file.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 12•17 years ago
|
||
Comment on attachment 318330 [details]
New Toolbar-small.png
Checking in browser/themes/winstripe/browser/Toolbar-small.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small.png,v <-- Toolbar-small.png
new revision: 1.14; previous revision: 1.13
done
Comment 13•17 years ago
|
||
Hrmm... comparing xp and vista small icons:
http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/878eb6749f48/browser/themes/winstripe/browser/Toolbar-small-aero.png
http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/878eb6749f48/browser/themes/winstripe/browser/Toolbar-small-aero.png
aero's disabled forwards seems to shift left compared to xp
Comment 14•17 years ago
|
||
Assignee | ||
Comment 15•17 years ago
|
||
Corrected an off by one pixel error with the disabled 16x16 forward button
Comment 16•17 years ago
|
||
Comment on attachment 318335 [details]
Toolbar-small-aero.png
Checking in browser/themes/winstripe/browser/Toolbar-small-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small-aero.png,v <-- Toolbar-small-aero.png
new revision: 1.6; previous revision: 1.5
done
Updated•17 years ago
|
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
You need to log in
before you can comment on or make changes to this bug.
Description
•