Closed
Bug 431023
Opened 17 years ago
Closed 15 years ago
Change the add-ons manager window dimensions to make it more usable
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
INVALID
People
(Reporter: faaborg, Unassigned)
References
Details
(Keywords: polish, Whiteboard: [polish-easy][polish-visual][polish-p2])
Attachments
(8 files)
The current default window size of the add-ons manager doesn't work well given tall items in the rich list view. I recommend we make the window 768 pixels tall. It would also be good if all of our default window sizes followed the golden ratio (http://en.wikipedia.org/wiki/Golden_ratio) in this case the window being taller than it is wide.
Comment 1•17 years ago
|
||
768 would be full-screen on a 1024*768 screen, right?
Comment 2•17 years ago
|
||
Am I missing something? Making the window 768px tall doesn't follow the golden ratio:
height/width = 768/520 = 1.4769230769230769230769230769231
Comment 3•17 years ago
|
||
Preserving the current width, a height of 841px would yield in the golden ratio!
Comment 4•17 years ago
|
||
Suggestion for the new dimensions: 432x700. This ratio follows the golden ratio.
Reporter | ||
Comment 5•17 years ago
|
||
>Am I missing something? Making the window 768px tall doesn't follow the golden
>ratio
I think if we make the window less wide we pick up a scroll bar in the rich list view. If 432x700 looks ok let's do it, otherwise making it tall enough to see results is more important than following the golden ratio.
Comment 7•17 years ago
|
||
Ugh, I spoke too soon! :-/
This neither looks nice, nor golden! Suggestions?
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Comment 8•17 years ago
|
||
Part of the problem could be that a screen (being the bounding box for windows) is wider than it is high. Pixels aren't necessarily square either. Also, a vertical orientation always looks different from a horizontal one, not only on computer screens. Attachment 317983 [details] looks much better if I rotate my screen.
Golden or not, we could make the window a bit higher, although comment 6 sounds like we shouldn't.
Comment 9•17 years ago
|
||
http://mxr.mozilla.org/mozilla/source/toolkit/mozapps/extensions/content/extensions.xul#58 is the code, and yes, this would be an l10n change.
So, does this block shipping? I wouldn't think so, even more so as the size of the window is persisted anyway, so if a user doesn't like it, the add-ons manager will come up at their preferred size the next time.
Comment 10•17 years ago
|
||
> yes, this would be an l10n change.
But only changing the en-US string value would be legitimate and not late-l10n, right?
Comment 11•17 years ago
|
||
Any check-in to something in locales/en-US isn't welcome at this point.
You can argue that this change doesn't break anything or doesn't warn anything. On the other hand, if it sucks for en-US it sucks for every locale.
Comment 12•17 years ago
|
||
(In reply to comment #11)
> On the other hand, if it sucks for en-US it sucks for every locale.
Sure. But as it stands, a change for every locale is not wanted. Patching en-US, while still not welcome, might be better than doing nothing.
Attachment 317981 [details] does look squeezed to me.
Comment 13•17 years ago
|
||
1024x768 is still a very common (the most common?) resolution, and you do not want this window covering up parts of the task bar. And of course, there will be those using lower resolutions than 1024x768. Aside from the ones living in the "dark ages", there are those who use lower resolutions because of bad eyesight (I've known people who do that because not all apps on Windows respond well to DPI changes, so they opt for a lower res instead), and there are also an increasing number of people using those new-fangled ultra-mobile PCs such as the popular Asus Eee. If there is a size increase, I think it should take these concerns into account.
Just enough of an increase so that the user could see two items after the recommended item should be enough to make the user want to scroll down if the user is interested. That would require only a modest size change, and if there is to be a size increase, I think that this would be the best justification for one.
Comment 14•17 years ago
|
||
This one doesn't look too bad, and monitors are wider than they are tall in 99% of cases I know of.
IT actually looks even better around 740 wide and 520 tall, because the scroll bar goes away with the default amount of suggested addons, but that might be pushing the limits of 800x600 if anyone still runs at that.
Updated•17 years ago
|
Summary: Make add-ons manager window 768 tall → Change the add-ons manager window dimensions to make it more usable
Whiteboard: needs decision on the new dimensions
Comment 15•17 years ago
|
||
I'd rather we wait until we can get this localized; I don't think the default is disastrous atm. It'd be nice polish, but not so nice that I want to bother with potential l10n headachery.
Comment 16•17 years ago
|
||
OK, I'm setting the target milestone to "future" then.
Assignee | ||
Updated•16 years ago
|
Product: Firefox → Toolkit
Comment 17•16 years ago
|
||
If someone wants to submit a patch and get ui-review then we can take this for 3.1
Whiteboard: [good first bug]
Updated•16 years ago
|
Target Milestone: Future → ---
Updated•16 years ago
|
Comment 18•16 years ago
|
||
Using the golden ratio for the whole window will always not look perfect for the possible range because the box with the recommended add-ons has another ratio there (and it is the main window element). So I suggest using the golden ration for the recommended add-ons box:
Recommended box:
width: 672
height: 415
Whole window:
width: 700
height: 562
Opinions?
Comment 19•16 years ago
|
||
Please provide screenshots of at least the themes pane as well as it is this pane that uses up most space.
Comment 20•16 years ago
|
||
the width of the preview pane is currently set to 220px. Should it be increased? I have no experience with themes.
Reporter | ||
Comment 23•16 years ago
|
||
I think it makes more sense to make the window taller than it is wide since users may have a long list of adddons (or this might encourage them to get a long list of addons). We don't really need as much horizontal space. Can we try switching the dimensions?
Comment 24•16 years ago
|
||
Alex, you can get an idea of what that would look like in attachment #317983 [details]
The text of a selected item (especially in the Get Add-ons view) is rather *scrunched*
Reporter | ||
Comment 25•16 years ago
|
||
Let's go with 480x640
Comment 26•16 years ago
|
||
480x640 seems pretty scrunched up in the themes view to me.
Updated•16 years ago
|
Attachment #336997 -
Flags: ui-review?(faaborg)
Comment 27•16 years ago
|
||
Comment on attachment 336997 [details]
480x640 screenshot
Alex, if you're happy that this looks ok then I'm happy to go with it. Feels very against the grain though.
Reporter | ||
Updated•16 years ago
|
Attachment #336997 -
Flags: ui-review?(faaborg) → ui-review+
Reporter | ||
Updated•16 years ago
|
Keywords: polish
Whiteboard: [good first bug] → [good first bug][polish-easy][polish-visual]
Reporter | ||
Comment 28•16 years ago
|
||
Would switching the orientation of the preview pane (so that the splitter was horizontal instead of vertical) cause any problems? If that change is easy enough I think we should try to do it at the same time as altering the default window dimensions.
Comment 29•16 years ago
|
||
Did we end up missing the string freeze again, but for 3.1 now?
Reporter | ||
Comment 30•16 years ago
|
||
uiwanted: figure out if we can take this as late l10n
Keywords: uiwanted
Comment 31•16 years ago
|
||
The proposed size isn't actually wide enough to accommodate all the possible buttons. I think this is going to have to slide for now and hopefully the UI update will make this unnecessary
Whiteboard: [good first bug][polish-easy][polish-visual] → [polish-easy][polish-visual]
Comment 32•16 years ago
|
||
I vote for a wider default. See bug 470268.
Reporter | ||
Comment 34•16 years ago
|
||
This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.
A secondary UI, but the current window size is kind of humorously small so the change should be identifiable.
Whiteboard: [polish-easy][polish-visual] → [polish-easy][polish-visual][polish-p2]
Comment 35•15 years ago
|
||
No longer needed as add-ons manager is being displayed in a page's content area in next Firefox
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•