test_nsIDownloadHistory.js fails when running against Thunderbird: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]" nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)" location: "JS frame :: ../../_tests/xpcshell-simple/test_docshell/unit/test_nsIDownloadHistory.js :: testLinkVistedObserver :: line 48" data: no] I'm filing this to get it tracked. Not sure if this is a core or a Thunderbird specific problem yet. Will post more info when I have it.

(In reply to comment #0) > test_nsIDownloadHistory.js fails when running against Thunderbird: > > [Exception... "Component returned failure code: 0x80570016 > (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]" nsresult: > "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)" location: "JS frame :: > ../../_tests/xpcshell-simple/test_docshell/unit/test_nsIDownloadHistory.js :: > testLinkVistedObserver :: line 48" data: no] So this bug is caused by us not building toolkit/components/history or toolkit/components/places. I think we should probably try changing the test to detect places (or lack therefore) like I have proposed for bug 431159. If I don't get any objections in the next day, then I'll go for it.

This is similar to what I did in bug 431159. Thunderbird doesn't build with any history in place; the reason the getService fails is because the docshell/ code assumes that older extensions will provide an nsGlobalHistory or nsGlobalHistory2 implementation and tries to use an adapter. This will always fail in the Thunderbird case. Therefore this code catches that and turns the test into a pass. Other tests (esp those in toolkit/components/places) will detect the lack of an appropriate history object for Firefox builds.

Comment on attachment 325300 [details] [diff] [review] Don't run the test if getService fails. bah - please make sure I'm cc'd to bugs that need my review. I don't always check my review queue. r=sdwilsh

Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/index.cgi/rev/b71578e7622a