User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008043011 Minefield/3.0pre Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008043011 Minefield/3.0pre Error Console error/warning/message context menu item "Copy" needs icon. See screenshot. Reproducible: Always

Comment on attachment 319270 [details] [diff] [review] Adds the copy icon to the error console's context menu >Index: toolkit/themes/gnomestripe/global/console/console.css >+menuitem:not([type]) { >+ -moz-binding: url("chrome://global/content/bindings/menu.xml#menuitem-iconic"); Just put class="menuitem-iconic" on the element itself? If this really needs to apply to other menu items you can add that class to those, but I don't see any. >+#menu_copy_cm { >+ list-style-image: url("moz-icon://stock/gtk-copy?size=menu");

Is this what you were aiming at?

Yes, like that, but without the .menuitem-iconic change to the CSS (.menuitem-iconic is styled in xul.css), though now that I think about it this means that we need to ensure that that class doesn't have negative effects on other platforms (e.g. breaking alignment issues between the copy menu item label and the other menuitems).

This is what I meant (also updated to trunk). Unfortunately it breaks the alignment on Mac (because iconic menu items have a lot more padding than non-iconic menuitems). I suppose we could just ifdef that for Linux, or use CSS to hide the icon box on non-Linux.

We should just add -moz-binding: url("chrome://global/content/bindings/menu.xml#menuitem-iconic"); to #menu_copy_cm.

The error console is dead.