When you pass illegal changes to email_in.pl, it replies to the sender about what's wrong: You tried to change the Priority field from P4 to P1 , but only the assignee or reporter of the bug, or a sufficiently empowered user may change that field. Frédéric Buclin wrote: > > @priority = P1 As you can see, the message is pretty ugly, because every newline from user-error.html.tmpl is displayed as is in the reply. These newlines are not a problem from the web browser because HTML doesn't render them. But they are obviously a problem in a text message. We should remove newlines from error messages before sending the email back to the sender.

This could be fixed by wrapping it in "FILTER collapse". However, if there was any <pre> formatting in the message, it would be destroyed. I think that's OK, though. This isn't significant enough for me to actually block a release on it, but I agree that it'd be nice to fix.

Comment on attachment 318862 [details] [diff] [review] patch, v1 No, you should just wrap message.txt.tmpl with FILTER collapse, I think.

Comment on attachment 318862 [details] [diff] [review] patch, v1 Okay, since you pointed out on IRC that ThrowUserError doesn't use message.txt.tmpl (nor would CodeError or TemplateError, etc.) this is the best and most centralized way to do this. However, this should be s/[\s\n]+/ /gms I think, no?

Comment on attachment 318862 [details] [diff] [review] patch, v1 message.txt.tmpl is not called by ThrowUserError().

Comment on attachment 318862 [details] [diff] [review] patch, v1 See above comment about regex.

The result is pretty much the same. :)

Comment on attachment 318864 [details] [diff] [review] patch, v2 Looks good to me.

tip: Checking in email_in.pl; /cvsroot/mozilla/webtools/bugzilla/email_in.pl,v <-- email_in.pl new revision: 1.19; previous revision: 1.18 done 3.0.4: Checking in email_in.pl; /cvsroot/mozilla/webtools/bugzilla/email_in.pl,v <-- email_in.pl new revision: 1.5.2.12; previous revision: 1.5.2.11 done