If anybody has the time to review this before Beltzner can, feel free to do so.

Comment on attachment 319000 [details] [diff] [review] Fix v1.0 This doesn't apply cleanly at the moment. Can you unbitrot? Also, request review from :rflint.

Now that bug 428071 and bug 406730 are in, I think we need to get this in ASAP. Then we can tell nightly users about the change and get them hammering away at it.

Does this apply?

Comment on attachment 319034 [details] [diff] [review] Fix v1.1 >Index: browser/themes/pinstripe/browser/browser.css >+#editBMPanel_folderTree treechildren::-moz-tree-twisty { >+#editBMPanel_folderTree treechildren::-moz-tree-twisty(open) { >+#editBMPanel_folderTree treechildren::-moz-tree-twisty(selected) { >+#editBMPanel_folderTree treechildren::-moz-tree-twisty(selected, open) { > #editBMPanel_folderTree treechildren::-moz-tree-row(selected) { These look unrelated to this bug? >+#browser > vbox > #sidebar, > sidebarheader { Why is just "#sidebar" sufficient? Is there some other document this applies to that has another element with ID "sidebar"? > #sidebar-box { >- -moz-appearance: dialog; > -moz-appearance: none; > } > #sidebar-splitter { >- background-image: none !important; >+ background-image: none !important; Are these sidebar changes related to this bug?

Does this bug also handle the styling of the status bar? As I see from other applications it should also get a lighter color when the window is inactive.

Kevin/Stephen: can we get your assistance here?

(In reply to comment #5) > These look unrelated to this bug? > ... > Are these sidebar changes related to this bug? I have no idea why these changes are part of the patch. They're from the patch that Kevin uploaded to bug 406730 (attachment 316755 [details] [diff] [review]). I have now removed everything that I thought was not related to this bug.

(In reply to comment #6) > Does this bug also handle the styling of the status bar? As I see from other > applications it should also get a lighter color when the window is inactive. Yes, it does get slightly lighter.

Comment on attachment 319074 [details] [diff] [review] Fix v1.3: remove unrelated changes a=beltzner I'm tempted to call for a clobber on OSX builds, but guess we can live without.

(In reply to comment #7) > Kevin/Stephen: can we get your assistance here? > Kevin has been working on this quite a bit. He may be able to comment on it more.

(In reply to comment #11) > Kevin has been working on this quite a bit. He may be able to comment on it > more. It was addressed in comment 9 :)

(In reply to comment #12) > (In reply to comment #11) > > Kevin has been working on this quite a bit. He may be able to comment on it > > more. > It was addressed in comment 9 :) > Ah, thanks! I am so behind ;)

mozilla/browser/themes/pinstripe/browser/places/organizer.css 1.15 mozilla/browser/themes/pinstripe/browser/browser.css 1.151 mozilla/browser/themes/pinstripe/browser/pageInfo.css 1.16 mozilla/browser/themes/pinstripe/browser/preferences/preferences.css 1.28 mozilla/toolkit/themes/pinstripe/global/console/console.css 1.15 mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css 1.48 mozilla/toolkit/themes/pinstripe/mozapps/downloads/downloads.css 1.32

I clobbered Mac to produce a new nightly: mozilla/tools/tinderbox-configs/firefox/macosx/CLOBBER 1.48

Please have a look at the latest comments on bug 406730 about the slowness of the transition between both states.

The sidebars on my build are only changing color at the top but not the rest. Works in the Library though.

(In reply to comment #17) > The sidebars on my build are only changing color at the top but not the rest. > Works in the Library though. Thanks for catching, Stephen. I've filed bug 432115 and attached a patch.

Looks good. Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050504 Minefield/3.0pre ID:2008050504