Closed
Bug 431999
Opened 17 years ago
Closed 17 years ago
Increase the right padding for the curved site identity button on Windows by 1px
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3
People
(Reporter: kliu, Assigned: kliu)
References
Details
(Keywords: polish)
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Gavin
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
beltzner
:
ui-review+
|
Details |
As the attached screenshot shows (top: XP, bottom: Vista), the amount of spacing on the right for the curved site icon does not match the amount of spacing on the left (6px left, 5px right).
This imbalance was the result of adding a second, mostly transparent border on the left, thus making it appear that the spacing has increased on the left when in fact the padding itself has not. Since this transparent border is not added to the right in the curved buttons, an extra pixel of padding should be added to compensate.
This change would also bring the right spacing in line with what is found in the RTL/native buttons, because the transparent border is added to both the right and left for RTL/native, so the spacing in RTL/native currently appears to be 6px on both sides.
Finally, I think that increasing the padding on the right by 1px is better than decreasing it on the left by 1px because, with the site button being the primary indicator of security for DV-SSL, I don't think it should decrease in size.
Assignee: nobody → kliu
Status: NEW → ASSIGNED
Attachment #319180 -
Flags: ui-review?(beltzner)
Attachment #319180 -
Flags: review?(gavin.sharp)
Updated•17 years ago
|
Attachment #319180 -
Flags: review?(gavin.sharp) → review+
Attachment #319211 -
Flags: ui-review?(beltzner)
Attachment #319180 -
Flags: ui-review?(beltzner)
Updated•17 years ago
|
Attachment #319211 -
Flags: ui-review?(beltzner) → ui-review+
Comment 3•17 years ago
|
||
Comment on attachment 319180 [details] [diff] [review]
patch
a1.9=beltzner
Attachment #319180 -
Flags: approval1.9+
Keywords: checkin-needed
Whiteboard: [needs ui-review beltzner]
Comment 4•17 years ago
|
||
mozilla/browser/themes/winstripe/browser/browser-aero.css 1.16
mozilla/browser/themes/winstripe/browser/browser.css 1.220
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Keywords: checkin-needed
Target Milestone: --- → Firefox 3
Comment 5•17 years ago
|
||
Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008051806 Minefield/3.0pre ID:2008051806
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•