Closed
Bug 432272
Opened 17 years ago
Closed 17 years ago
Use -moz-padding-end and -moz-padding-start instead of padding-right and padding-left in tree(-aero).css
Categories
(Toolkit :: XUL Widgets, defect)
Toolkit
XUL Widgets
Tracking
()
RESOLVED
FIXED
mozilla1.9
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Keywords: rtl)
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
Follow-up from bug 431195 comment 13. I'll post a patch as soon as bug 431195 lands, to make the padding rules RTL-agnostic.
|
Assignee | |
Updated•17 years ago
|
Summary: Use -moz-padding-end instead of padding-right and padding-left in tree(-aero).css → Use -moz-padding-end and -moz-padding-start instead of padding-right and padding-left in tree(-aero).css
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•17 years ago
|
||
Simple patch to use -moz-padding-{start,end} instead of padding-{left,right} (or combined padding CSS rules).
Attachment #319744 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Updated•17 years ago
|
Attachment #319744 -
Flags: review?(gavin.sharp) → review?(dao)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 319744 [details] [diff] [review]
Patch (v1)
Can you do the same for gnomestripe?
>@@ -260,21 +260,27 @@ treecolpicker:hover:active {
> border-top: 2px solid;
> border-right: 1px solid;
> border-bottom: 1px solid;
> border-left: 2px solid;
> -moz-border-top-colors: ThreeDShadow -moz-Dialog;
> -moz-border-right-colors: ThreeDShadow;
> -moz-border-bottom-colors: ThreeDShadow;
> -moz-border-left-colors: ThreeDShadow -moz-Dialog;
>- padding: 1px 4px 0px 5px;
>+ padding-top: 1px;
>+ padding-bottom: 0px;
>+ -moz-padding-start: 4px;
>+ -moz-padding-end: 5px;
You mixed up start/end.
> .treecol-image:hover:active {
>- padding: 1px 1px 0px 2px;
>+ padding-top: 1px;
>+ padding-bottom: 0px;
>+ -moz-padding-start: 1px;
>+ -moz-padding-end: 2px;
same here
Attachment #319744 -
Flags: review?(dao) → review-
|
|
Assignee | |
Comment 3•17 years ago
|
||
(In reply to comment #2)
> (From update of attachment 319744 [details] [diff] [review])
> Can you do the same for gnomestripe?
Sure, done. I looked at pinstripe's tree.css as well, but it was all handled already.
I also went ahead and corrected a few margin rules as well.
> You mixed up start/end.
Oops! Fixed.
Attachment #319744 -
Attachment is obsolete: true
Attachment #320042 -
Flags: review?(dao)
|
|
Assignee | |
Updated•17 years ago
|
OS: Windows Vista → All
Hardware: PC → All
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 320042 [details] [diff] [review]
Patch (v1.1)
>Index: toolkit/themes/gnomestripe/global/tree.css
> .treecol-image:hover:active {
>- padding: 0px 0px 0px 2px;
>+ padding-top: 0px;
>+ padding-bottom: 0px;
>+ -moz-padding-start: 2px;
>+ -moz-padding-end: 0px;
As done elsewhere, I'd write this as:
padding: 0;
-moz-padding-start: 2px;
Attachment #320042 -
Flags: review?(dao) → review+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Fixed Dao's comment 4. Requesting approval. This is a CSS-only change with no impact on LTR locales, while improving things a bit for RTL locales.
Attachment #320042 -
Attachment is obsolete: true
Attachment #320049 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #320049 -
Flags: approval1.9? → approval1.9+
|
||
Updated•17 years ago
|
Keywords: checkin-needed
|
|
||
Comment 6•17 years ago
|
||
mozilla/toolkit/themes/gnomestripe/global/tree.css 1.12
mozilla/toolkit/themes/winstripe/global/tree-aero.css 1.3
mozilla/toolkit/themes/winstripe/global/tree.css 1.15
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
You need to log in
before you can comment on or make changes to this bug.
Description
•