Closed Bug 432355 Opened 17 years ago Closed 16 years ago

Color border of site button to match gradients for SSL and EV states

Categories

(Firefox :: Theme, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

VERIFIED INVALID

People

(Reporter: faaborg, Unassigned)

References

Details

(Keywords: polish, Whiteboard: [polish-easy] [polish-visual])

Attachments

(3 files)

in https://bugzilla.mozilla.org/show_bug.cgi?id=417844#c104 Matt Cosentino writes: "There was a lot of talk about using the colored border of the gradients but I didn't see anyone that actually did it. Here is how it looks on XP. These are screenshots from a working implementation that includes hover and active states(not shown)." https://bugzilla.mozilla.org/attachment.cgi?id=319056 I think this really helps aesthetically, with making the control look like a button, and with mirroring the appearance of the forward button for internal consistency in the theme. Requesting blocking to pick up wanted. Matt: can you post a patch?
Flags: blocking-firefox3?
If we go for this approach we should bring back the lighter lines at the top and bottom of the gradient since they were removed to work better with the gray native color of text field borders.
could somebody post the css for this? i'm curious as to how it's possible.
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
I'm working on the patch, I'll try to post something later today.
Attached patch patch (deleted) — Splinter Review
Attached image navbar-textbox-buttons-aero.png (deleted) —
Attached image navbar-textbox-buttons.png (deleted) —
Hopefully I did that right. :) I tested this in both Vista and XP, in both default and classic themes.
Attachment #319971 - Flags: review?
Comment on attachment 319971 [details] [diff] [review] patch Dao, is it a part you can review?
Attachment #319971 - Flags: review? → review?(dao)
Comment on attachment 319971 [details] [diff] [review] patch this needs ui-review
Attachment #319971 - Flags: review?(dao)
Depends on: 431983
Attachment #319971 - Flags: ui-review?(beltzner)
Note that the given patch styles the identity button's depressed state inconsistently. I added bug 431983 as a dependency therefore.
Comment on attachment 319971 [details] [diff] [review] patch ui-r=beltzner, definitely This ui-r is also for the revised gradients as per comment 1
Attachment #319971 - Flags: ui-review?(beltzner) → ui-review+
Matt, could you come up with a new patch which includes the parts mentioned in comment 1?
I recommend we use full images like the OS X theme and wontfix this, but still setting the polish keywords/whiteboard terms to track.
Keywords: polish
Whiteboard: [polish-easy] [polish-visual]
Alex, I absolutely agree with you. As close as I was able to get with just using the rounded borders, it just isn't quite good enough.
Aha! Which is now easily doable with 3.1's addition of -moz-border-image. :) I'll get this patched up.
filed follow up bug 462977 for using -moz-border-image for the site buttons.
Matt - still interested in getting this bug fixed? Once you get a patch posted, you should request review from dao@mozilla.com. We'll need it soon if it is going to make 3.1
resolving as invalid in favor of bug 462977
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: