Closed
Bug 432757
Opened 17 years ago
Closed 17 years ago
darken .ac-url-title for vista
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: beltzner, Assigned: beltzner)
Details
Attachments
(3 files, 1 obsolete file)
|
(deleted),
patch
|
Gavin
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details |
before patch (screenshot)
.ac-url-title was switched from green (#006600) to a light blue (#0066cc) on Vista since green isn't a colour that's used all that often, and that light blue is what's used in the Vista UI for links.
Trouble is, in the context of the awesomebar, that's a lot of light blue, and especially on large monitors it ends up feeling very overpowering.
We should darken the colour. I tried out a bunch of hues, and a simple darkening to 0055bb ended up looking pretty good.
Attachment #319912 -
Flags: review?(gavin.sharp)
|
Assignee | |
Comment 1•17 years ago
|
||
Whoops. This is the right patch.
Attachment #319912 -
Attachment is obsolete: true
Attachment #319913 -
Flags: review?(gavin.sharp)
Attachment #319912 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Comment 2•17 years ago
|
||
|
|
Assignee | |
Comment 3•17 years ago
|
||
|
||
Comment 4•17 years ago
|
||
Comment on attachment 319913 [details] [diff] [review]
change to #0055bb
Are those the right screenshots? I can't tell the difference between them...
Attachment #319913 -
Flags: review?(gavin.sharp) → review+
|
||
Comment 5•17 years ago
|
||
Comment on attachment 319913 [details] [diff] [review]
change to #0055bb
eh, just land it. Its definitely a darker color... :)
Attachment #319913 -
Flags: approval1.9+
|
|
||
Updated•17 years ago
|
Keywords: checkin-needed
|
|
||
Updated•17 years ago
|
Assignee: nobody → beltzner
|
|
||
Comment 6•17 years ago
|
||
mozilla/browser/themes/winstripe/browser/browser-aero.css 1.17
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
|
|
Assignee | |
Comment 7•17 years ago
|
||
(In reply to comment #4)
> (From update of attachment 319913 [details] [diff] [review])
> Are those the right screenshots? I can't tell the difference between them...
Yeah, it's really subtle, but makes a difference with really bright screens. Thanks, gents!
Target Milestone: Firefox 3 → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•