Closed Bug 432817 Opened 17 years ago Closed 16 years ago

Invalidate whole window when focus changes

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9.1a1

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(2 files)

Bug 54488 introduced a call to nsChildView::Invalidate in order to redraw widgets that change their blue / clear look. However, it looks like [childView sendFocusEvent] is only called on the _focused_ nsChildView - sometimes that's not enough. Steps to reproduce: 1. Open a Firefox window. 2. Load a page that's long enough to require a scrollbar. 3. Choose View -> Sidebar -> History. 4. Focus the search field in the history sidebar. 5. Click on the Desktop in order to deactivate the Firefox window. Expected results: The content view scrollbar should become transparent. Actual results: The content view scrollbar stays blue, see screenshot. Fixing this bug might also fix bug 432131 which has similar symptoms.
Attached patch Fix v1.0 (deleted) — Splinter Review
Duh. I didn't think it was this easy. Sadly, it doesn't fix bug 432131. I tried ->Invalidate(PR_TRUE), but that makes things worse...
Attachment #319988 - Flags: review?(joshmoz)
Comment on attachment 319988 [details] [diff] [review] Fix v1.0 Clearing review flag because bug 54488 was backed out.
Attachment #319988 - Flags: review?(joshmoz)
This has been fixed by bug 432131.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Target Milestone: --- → mozilla1.9.1a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: