Closed Bug 433009 Opened 17 years ago Closed 16 years ago

Front Themes page under 'We Recommend' doesn't check version compatibility

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

x86
Windows XP
defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: fittysix, Assigned: cpollett)

References

()

Details

Attachments

(3 files)

The page in the URL (clicking themes on the front AMO page) doesn't seem to do a version compatibility check. I am running Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050906 Minefield/3.0pre and that page is currently offering https://addons.mozilla.org/en-US/firefox/addon/6070 as a theme, with the 'Add to Firefox' button green and working. The individual add-on page has the "This add-on is for older versions of Firefox" message with the 'Add to Theme' button grayed and unavailable.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
Reopening on the grounds that bug 415263 did not seem to fix this as shown here: https://preview.addons.mozilla.org/en-US/firefox/browse/type:2 The page is still showing "add to Firefox" regardless of whether the extension is compatible with the users version of Firefox.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Target Milestone: --- → 3.4.3
Assignee: nobody → cpollett
Status: REOPENED → NEW
Attached patch patch to fix problem (deleted) — Splinter Review
When placing the featured element unto the themes category landing page the variable used to check compatible apps was not passed causing the problem. The fix was to pass this variable.
Attachment #323403 - Flags: review?(fligtar)
Severity: normal → major
This fixes Zotero too, right? https://preview.addons.mozilla.org/en-US/firefox/addon/3504 has a green install button, but when the installTrigger runs, says it's not compatible with Minefield 3.0pre.
nom'ing this for blocking firefox3. morgamic, can we get this fixed before we ship fx3?
Flags: blocking-firefox3?
Attachment #323403 - Flags: review+
thanks for the review laura. Checked into r14504
Status: NEW → RESOLVED
Closed: 17 years ago16 years ago
Keywords: push-needed
Resolution: --- → FIXED
Attachment #323403 - Flags: review?(fligtar)
(In reply to comment #6) > This fixes Zotero too, right? > https://preview.addons.mozilla.org/en-US/firefox/addon/3504 has a green install > button, but when the installTrigger runs, says it's not compatible with > Minefield 3.0pre. Scratch that, I had a tricked-out |general.useragent.override| value :-(
See comment 11; compatibility checking is back and working on preview. Verified FIXED
Status: RESOLVED → VERIFIED
Flags: blocking-firefox3? → blocking-firefox3+
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: