Soothsayer Reporter
	Description • 16 years ago

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9pre) Gecko/2008050812 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9pre) Gecko/2008050812 Minefield/3.0pre

See comments from number 28 in bug 428843. This causes undesired side effects with an inaccurate message.

Following on from the above patch, Firefox now prompts to save 'tabs' on exit, even when none are open.

Apart from the message being inaccurate because no tabs are open, this is an extremely frustrating annoyance.

When no tabs are open, there should be no prompt. In the rare event that the user accidentally closes the browser, they can always go to the most recent one in their history when they start.

As things now stand, the user would either have to
1.) Put up with the prompt each and every time they close the browser.
2.) Disable the prompt and never get prompted, even if they have multiple tabs open.
3.) disable the prompt but have the session restored every time, thus bypassing their homepage.

I feel the patch for 428843 should therefore be backed out.

Reproducible: Always

Steps to Reproduce:
1. Ensure preference browser.tabs.warnOnClose = true
2. Open the browser.
3. Close the browser
Actual Results:  
You get an erroneous (and unnecessary) prompt.

Expected Results:  
The browser should close without prompting.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 2 • 16 years ago

This is not a blocker, and in my opinion should be WONTFIX. Being able to save the state of your browser on shutdown should not be tied to having multiple tabs open.

	Andrew Sachen
	Comment 3 • 16 years ago

I thought that's what the "Show my windows and tabs from the last time" feature in the Startup options was for.

	Mike Connor [:mconnor]
	Comment 4 • 16 years ago

that's a default, not a choice.  sometimes I want to save a session, but often I don't...

	Andrew Sachen
	Comment 5 • 16 years ago

True. Perhaps this could be three options instead of a boolean selection? Something like
0: never prompt
1: always prompt
2: prompt only on multiple tabs
I don't like that it "took over" a feature, especially cause I liked it the way it was, and now it's just annoying to me.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 6 • 16 years ago

I'm sorry that it's annoying you, but there's no logic to only asking if a session should be saved in a case where there are multiple tabs - what if I'm editing a wiki page in a single tab and that's important? Must I open another tab in order to be able to save my session?

There's still the "Always warn me when closing multiple tabs" preference that will prevent accidental dataloss, even in the case where a user has said that they never want their session to be saved.

Also: I've filed bug 433123 to track better ways of exposing/describing the UI here.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 7 • 16 years ago

And bug 433124 for updating the message.

	Soothsayer Reporter
	Comment 8 • 16 years ago

(In reply to comment #6)
> but there's no logic to only asking if a session should be saved in a case where there are multiple tabs
>

Actually there is a great deal of logic to this option.

The original purpose of this prompt was to prevent accidental closing of multiple tabs when you only wanted to close the one you were looking at (i.e. you forgot you had multiple tabs open and when wanting to close a tab, you instinctively clicked on the X in the top right by mistake).

When you have no tabs open (or only the one), then this ceases to be an issue and clicking the X in the top right is exactly what you wanted to do.

Session restore should have its own preference and not hijack this one.

I therefore respectfully request this is re-opened and renominated for blocking.

	Andrew Sachen
	Comment 9 • 16 years ago

Agreed. Also, if only one tab is open, the user tends to know what site it is, and if they wish to get back to it again later, it's not hard to remember. But five tabs gets hard to remember where you are and what you're doing.

	Michael Lefevre
	Comment 10 • 16 years ago

"This is not a blocker, and in my opinion should be WONTFIX. Being able to save
the state of your browser on shutdown should not be tied to having multiple
tabs open."

Maybe it shouldn't be, but it is, and was in Firefox 2.  When you say your opinion is that this is WONTFIX, are you saying that you think the multiple-tab warning and pref UI is good now? Or just that you would rather have the session save stuff be better and the tab close warning being whacky until bug 433123 is fixed?

"What if I'm editing a wiki page in a single tab and that's important?"

Then you can see your important wiki page and you don't deliberately close that window.  You only need to be warned if you didn't remember that wiki page edit was open in another hidden tab.

	Marco Zehe (:MarcoZ)
	Comment 12 • 16 years ago

I also agree that this is majorly annoying for when only a single tab is open. Apart from the wrong message, for keyboard users this means at least 1 extra keystroke: After closing the window with ALT+F4, or CTRL+W on the last open tab, focus lands on the "Save..." button. One has to press either ALT+Q, or Tab and then Space, to quit without saving.

Aside from that: Localizers will not appreciate the fact that a new string gets added this late in the game to show a proper message for this particular instance of the dialog. That should also be considered.

	Daniel.S
	Comment 13 • 16 years ago

No matter which behaviour is desired. In some cases there should be no promt:
* closing a single tab with about:blank opened or
* clicking restart in the AUS (where session restore is in effect anyway)

	:Gavin Sharp [email: gavin@gavinsharp.com] Assignee
	Comment 14 • 16 years ago

(In reply to comment #13)
> No matter which behaviour is desired. In some cases there should be no promt:
> * closing a single tab with about:blank opened or

You're probably right - file a bug?

> * clicking restart in the AUS (where session restore is in effect anyway)

We already don't show the prompt when restarting. If you've seen otherwise, please file a bug and CC me.

	Damian Shaw [Quan]
	Comment 15 • 16 years ago

Is this why now when you just have the download manager open and you close it you get the full "Save & Exit" warning?

	Dave Garrett
	Comment 16 • 16 years ago

Comment #5 makes the most sense here.  I think the best way to do this in the GUI would be to have both a "warn if closing multiple tabs" and also a "always prompt for session restore on exit" checkbox.  (the second requiring the first to be selected)  The reason I say this, is that there's also the OTHER case we're not talking about here:  the "close other tabs" context menu option for tabs.  This option is NOT just about session restore.

Regardless of what anyone's opinions are on this matter, this sort of thing really shouldn't be changed 3 seconds before RC1 is getting ready.  In addition to the lack of testing/scrutiny this change will get, the strings are supposed to be frozen now and keeping this in would require a string change for the case of only one tab on exit.  I think the safest thing to do is to back this out for the time being, get RC1 done and out, then debate this and re-land with the needed GUI changes one way or the other.

	:Gavin Sharp [email: gavin@gavinsharp.com] Assignee
	Comment 17 • 16 years ago

Re-adds the "don't show quit dialog with one page open" logic.

	Lucas Malor (mail: c6kfnkn2uc AT snkmail DOT c0m)
	Comment 18 • 16 years ago

> Comment #5 makes the most sense here.

I agree. Anyway I think Firefox should prompt never for a blank page only.
See also my enhancement suggestion here: Bug 433147

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 19 • 16 years ago

(In reply to comment #8)
> The original purpose of this prompt was to prevent accidental closing of
> multiple tabs when you only wanted to close the one you were looking at (i.e.
> you forgot you had multiple tabs open and when wanting to close a tab, you
> instinctively clicked on the X in the top right by mistake).

No, that's the original purpose of the "Are you sure you want to close N tabs" warning.

The purpose of this dialog, which is *new in Firefox 3*, is to allow users to choose to save their state on exit in order to resume where they left off.

> When you have no tabs open (or only the one), then this ceases to be an issue
> and clicking the X in the top right is exactly what you wanted to do.

Yes, but what if you need to save that state. Perhaps you're going home for the day, or you need to shut down your computer, or you just want to quit the browser, but you don't want to lose your current location, your back/forward state, your session cookies, your half-written content ... it's possible to need all of those aspects of a single tab. Only offering to save multi-tab sessions is an inappropriate blending of the "Are you sure you want to close N tabs" warning and this new feature.

> Session restore should have its own preference and not hijack this one.

This is a good point, and I hadn't realized that checking "[ ] Do not ask me again" and selecting "Quit" also disables the multiple window prompt in cases where the browser is not about to quit. The bugs I filed will be able to resolve this in the future, but it leads to a problem for users right now.

(In reply to comment #10)
> Maybe it shouldn't be, but it is, and was in Firefox 2.  When you say your
> opinion is that this is WONTFIX, are you saying that you think the 

No, this feature didn't exist in Firefox 2. At all. So it's not the same as anything.

> Then you can see your important wiki page and you don't deliberately close that
> window.  You only need to be warned if you didn't remember that wiki page edit
> was open in another hidden tab.

That really doesn't help me if I have to close my browser because it's the end of the day, or my system is clamoring to restart because I've installed some HP printer drivers, etc.

(In reply to comment #12)
> Aside from that: Localizers will not appreciate the fact that a new string gets
> added this late in the game to show a proper message for this particular
> instance of the dialog. That should also be considered.

No new string has been added, Marco.

(In reply to comment #17)
> Re-adds the "don't show quit dialog with one page open" logic.

I guess this is the right thing to do for now. Thanks to reporter for pointing out the error in my earlier assertion, and to Gavin for putting together the patch.

(morphing the title of this bug to reflect the actual issue a little better)

	Mike Connor [:mconnor]
	Comment 20 • 16 years ago

Comment on attachment 320374 [details] [diff] [review]
patch

This is the right thing to do for now.  Need to loop back on this when we can change strings and UI.

	davesalle
	Comment 21 • 16 years ago

I agree with the original poster. This feature is quite annoying.

	Dave Garrett
	Comment 22 • 16 years ago

Another bug this causes:  prompt when closing the error console, add-on manager, etc. after last Firefox window is already closed.  ;)

	u88484
	Comment 23 • 16 years ago

Well technically you still have a tab open but you just have the tab bar set to hide when only one tab is open.  Maybe the dialog should be changed to say tab(s)

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 24 • 16 years ago

2008-05-10 08:52	
mconnor%steelgryphon.com 	
mozilla/browser/components/nsBrowserGlue.js 	1.94 	12/2