Closed
Bug 433258
Opened 17 years ago
Closed 5 years ago
Don't use padding in the Certificate Viewer's "Field Value" textbox
Categories
(Core :: Security: PSM, defect, P5)
Core
Security: PSM
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: adelfino, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: polish, Whiteboard: [polish-easy][psm-easy][psm-cert-manager][psm-backlog])
Attachments
(1 file)
|
(deleted),
image/png
|
Details |
Certificate viewer textbox using padding.
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008051109 Minefield/3.0pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008051109 Minefield/3.0pre Per bug 157846, padding is not correctly added to textboxes, so we should not use it in the UI. See screenshot. Reproducible: Always
|
Reporter | |
Comment 1•17 years ago
|
||
|
|
Reporter | |
Updated•17 years ago
|
Version: unspecified → Trunk
|
|
Reporter | |
Updated•17 years ago
|
OS: Windows XP → All
Hardware: PC → All
|
||
Updated•16 years ago
|
Component: Theme → Themes
Product: Firefox → Toolkit
QA Contact: theme → themes
|
||
Comment 3•15 years ago
|
||
is this going to be a css-only fix? I have been trying to identify the css that affects the padding, here is my best guess: http://mxr.mozilla.org/mozilla-central/source/layout/forms/resources/content/xbl-forms.css
|
|
||
Comment 4•15 years ago
|
||
or perhaps it is this: http://mxr.mozilla.org/mozilla-central/source/layout/style/forms.css#148
|
|
||
Comment 5•15 years ago
|
||
Not sure what this bug's point is. If attachment 320462 [details] is the only issue we're talking about, then fundamentally changing the way we style textboxes doesn't seem worthwhile.|
|
||
Comment 6•15 years ago
|
||
... also, what's the alternative for padding? I'm assuming it's there for a reason, so we don't just want to remove it.
|
|
Reporter | |
Comment 7•15 years ago
|
||
See bug 157846 for the back end bug. My request here is to avoid using padding in Firefox for now, as a work around.
|
|
||
Comment 8•15 years ago
|
||
Same questions again... 1) What would we use instead of padding? 2) Are there other manifestations of bug 157846, besides the screenshot attached to this bug? That screenshot doesn't look severe enough to justify such a workaround. (Or is your request to remove the padding only for that specific textbox?)
|
|
Reporter | |
Comment 9•15 years ago
|
||
Yes, I suggest removing the padding only for that specific box. Don't know if there are more occurrences of this bug.
|
|
||
Updated•15 years ago
|
Assignee: nobody → kaie
Component: Themes → Security: UI
Product: Toolkit → Core
QA Contact: themes → ui
Summary: Don't use padding in textboxes → Don't use padding in the Certificate Viewer's "Field Value" textbox
|
||
Updated•15 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Updated•14 years ago
|
Assignee: kaie → nobody
Whiteboard: [polish-easy] → [polish-easy][psm-easy][psm-cert-manager]
Blocks: 1029832
Component: Security: UI → Security: PSM
Priority: -- → P5
Whiteboard: [polish-easy][psm-easy][psm-cert-manager] → [polish-easy][psm-easy][psm-cert-manager][psm-backlog]
|
||
Comment 12•6 years ago
|
||
(In reply to SresthaSrivastava [:srestha] from comment #11)
Hey, can I take this up?
Absolutely. You don't need to ask, especially (in PSM) for anything with [psm-would-take-patch] or [psm-easy] in the whiteboard. Just assign it to yourself (if you can) or post a patch. Feel free to reach out to Dana or myself on IRC in #security if you need.
(In reply to SresthaSrivastava [:srestha] from comment #13)
Hey, how do I self assign it?
In the "People" section at the top of this bug, there should be a "Take" button near the "Assignee" field. If you click that and then click "Save Changes" it should assign you.
New certificate viewer.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•