Closed Bug 433361 Opened 17 years ago Closed 15 years ago

API for search should have a param to specify inclusion of sandboxed addons.

Categories

(addons.mozilla.org Graveyard :: API, enhancement, P1)

Product:
addons.mozilla.org Graveyard
Component:
API
Type:
enhancement

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: laura, Assigned: davedash)

References

Details

(Whiteboard: [z])

Attachments

(1 obsolete file)

This is a follow on from bug 415263. In order to make the Addons Manager work as expected, the API is now returning only public add-ons. We need to add a parameter that allows the client to specify all (including sandboxed) addons.
I should point out that we also discussed changing the XML significantly, so we return one stanza per version, with a matching install element per version of the addon, and application version information per addon version.
As I mentioned in bug 415263, I'd rather this default to show all and have a param to filter the results to show only public add-ons.
Yes, you are correct, sorry about that.
Kicking out of 3.5 - not related to Dev CP revamp.
Target Milestone: 3.5 → ---
Target Milestone: --- → 5.0.2
Target Milestone: 5.0.2 → Future
As an API user, I really would like to see this happen.
Attached patch patch v1 (obsolete) (deleted) — — Splinter Review
I have not tested it yet, but it adds the exp=on switch like normal add-ons browsing.
Attachment #402067 - Flags: review?(laura)
Laura, can you take a look at this when you get a chance?
Severity: normal → enhancement
Priority: -- → P3
Blocks: 441250
Can anyone test/modify/review my patch? AMJ (https://wiki.mozilla.org/Japan/AMJ) team would like to implement this feature in Q1 2010. Thanks in advance.
SAMO is getting reworked in 5.7 (february). Let's try to get this in then.
Assignee: laura → dd
Priority: P3 → P5
Whiteboard: [z]
Target Milestone: Future → 5.7
Is it still worth looking at the patch or should it wait for the new SAMO?
Comment on attachment 402067 [details] [diff] [review] patch v1 (In reply to comment #12) > Is it still worth looking at the patch or should it wait for the new SAMO? don't worry about it
Attachment #402067 - Attachment is obsolete: true
Attachment #402067 - Flags: review?(laura)
Blocks: 543559
Target Milestone: 5.7 → 5.8
Kicking this up to P1 with bug 543559
Priority: P5 → P1
So I believe the discussion is, for API version < 1.5 , sandboxed addons won't be shown without a parameter (e.g. ?show_sandbox=1) After v1.5 showing sandbox'd addons will be the default and can be hidden with (?hide_sandbox=1)
for API versions < 1.5 there is no way to show sandbox add-ons. After 1.5, showing them is the default and they can be hidden with a flag.
great, even easier.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
(In reply to comment #16) > for API versions < 1.5 there is no way to show sandbox add-ons. After 1.5, > showing them is the default and they can be hidden with a flag. I can see sandboxed add-ons for v1.2: https://preview.addons.mozilla.org/z/en-US/firefox/api/1.2/search/firebug/all/100/macosx/3.6 And the hide_sandbox param doesn't work: https://preview.addons.mozilla.org/z/en-US/firefox/api/1.2/search/firebug/all/100/macosx/3.6?hide_sandbox=1 https://preview.addons.mozilla.org/z/en-US/firefox/api/1.5/search/firebug/all/100/macosx/3.6?hide_sandbox=1 I think this works as expected: https://preview.addons.mozilla.org/z/en-US/firefox/api/1.5/search/firebug/all/100/macosx/3.6
Still? I verified that these are working as expected. (In reply to comment #18) > (In reply to comment #16) > > for API versions < 1.5 there is no way to show sandbox add-ons. After 1.5, > > showing them is the default and they can be hidden with a flag. > > I can see sandboxed add-ons for v1.2: > https://preview.addons.mozilla.org/z/en-US/firefox/api/1.2/search/firebug/all/100/macosx/3.6 > > And the hide_sandbox param doesn't work: > https://preview.addons.mozilla.org/z/en-US/firefox/api/1.2/search/firebug/all/100/macosx/3.6?hide_sandbox=1 > https://preview.addons.mozilla.org/z/en-US/firefox/api/1.5/search/firebug/all/100/macosx/3.6?hide_sandbox=1 > > I think this works as expected: > https://preview.addons.mozilla.org/z/en-US/firefox/api/1.5/search/firebug/all/100/macosx/3.6
Hmm, now it seem to work as expected. Great!!
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: