User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; .NET CLR 1.0.3705; InfoPath.1; .NET CLR 1.1.4322; MS-RTC LM 8; .NET CLR 2.0.50727) Build Identifier: 3.1.4+ If you save a search as a particular name (e.g. 'test'), edit the search and then try to re-save it as 'Test' (i.e., exactly the same name but of a different case) the database throws a duplicate error and fails. This throws up an error message and the change is not reflected in the database. Reproducible: Always Steps to Reproduce: 1. Run a saved search. 2. Click edit search. 3. Without making changes, click search again. 4. Try to save the search with the same name, but of different case. Actual Results: Error message is thrown, change is not saved. Expected Results: Saved search should be renamed as the new name, and we should get the 'Your search named Test has been updated.' message. The module that failed was: DBD::mysql::db

I can reproduce on both 3.0.4 and 3.1.4.

This patch not only fixes the DB crash, but also allows the query to be renamed when the case is different.

Comment on attachment 320743 [details] [diff] [review] patch, v1 Sure, looks fine. This is a good case for why we should always use numeric ids for things.

tip: Checking in buglist.cgi; /cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <-- buglist.cgi new revision: 1.374; previous revision: 1.373 done Checking in Bugzilla/Search/Saved.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Saved.pm,v <-- Saved.pm new revision: 1.7; previous revision: 1.6 done 3.0.4: Checking in buglist.cgi; /cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <-- buglist.cgi new revision: 1.351.2.9; previous revision: 1.351.2.8 done Checking in Bugzilla/Search/Saved.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Saved.pm,v <-- Saved.pm new revision: 1.3.2.2; previous revision: 1.3.2.1 done