Closed
Bug 433740
Opened 16 years ago
Closed 16 years ago
itemDeleted event not fired when item is deleted from trash
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9
People
(Reporter: rain1, Assigned: rain1)
References
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
(local mail folders)
When an item is deleted from trash, an itemDeleted notification is not sent for the message.
The itemDeleted notification works for messages shift-deleted from mail folders, or for the Empty Trash option, but not for messages deleted individually from trash.
The patch fixes this by adding a check to find out whether the item is deleted from the trash.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #320951 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•16 years ago
|
Attachment #320995 -
Flags: superreview?(bienvenu)
Attachment #320995 -
Flags: review?(bienvenu)
|
||
Updated•16 years ago
|
Attachment #320995 -
Flags: superreview?(bienvenu)
Attachment #320995 -
Flags: superreview+
Attachment #320995 -
Flags: review?(bienvenu)
Attachment #320995 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 2•16 years ago
|
||
Thanks for the patch, Siddharth!
Checking in mailnews/local/src/nsLocalMailFolder.cpp;
/cvsroot/mozilla/mailnews/local/src/nsLocalMailFolder.cpp,v <-- nsLocalMailFolder.cpp
new revision: 1.581; previous revision: 1.580
done
->FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
|
|
||
Comment 3•16 years ago
|
||
And i don't know what's up with cvs, or perhaps bonsai, the checkin comment looks normal here...
|
|
Assignee | |
Comment 4•16 years ago
|
||
The patch also caused an extra itemDeleted to be fired when an item was moved out of the trash into a folder. While the itemDeleted is quite harmless (an itemMoveCopyCompleted is also fired for the same messages before the itemDeleted), it's a good idea to fix this.
Attachment #320995 -
Attachment is obsolete: true
Attachment #323346 -
Flags: superreview?(bienvenu)
Attachment #323346 -
Flags: review?(bienvenu)
|
|
||
Updated•16 years ago
|
Attachment #323346 -
Flags: superreview?(bienvenu)
Attachment #323346 -
Flags: superreview+
Attachment #323346 -
Flags: review?(bienvenu)
Attachment #323346 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Updated•16 years ago
|
Attachment #320995 -
Attachment description: updated patch, fixes coding style issue → [checked in] updated patch, fixes coding style issue
Attachment #320995 -
Attachment is obsolete: false
|
|
||
Comment 5•16 years ago
|
||
Comment on attachment 323346 [details] [diff] [review]
[checked in] patch to fix regression introduced in moving items out of trash
Checking in mailnews/local/src/nsLocalMailFolder.cpp;
/cvsroot/mozilla/mailnews/local/src/nsLocalMailFolder.cpp,v <-- nsLocalMailFolder.cpp
new revision: 1.585; previous revision: 1.584
Attachment #323346 -
Attachment description: patch to fix regression introduced in moving items out of trash → [checked in] patch to fix regression introduced in moving items out of trash
|
|
||
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•