Axel asked me over an IRC conversation yesterday to ask for approval before commiting our string changes/updates. I'm about to attach to this bug the diffs. Some of these translations have contributed by Ubuntu-l10n-he people, which for some reasons decided to fix translations in Ubuntu Launchpad instead of notifying us so we'll be able to pack it for every other system.

Comment on attachment 320986 [details] [diff] [review] /l10n/he/extensions (14/05/08) This patch should be obsolete, and it's not the right thing to do from a mark-up point of view. For the real fix, see http://bonsai-l10n.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=reporterOverlay.dtd&branch=&root=/l10n&subdir=/l10n/he/extensions/reporter/chrome&command=DIFF_FRAMESET&rev1=1.6&rev2=1.7

Comment on attachment 320984 [details] [diff] [review] /l10n/he/browser (14/05/08) I don't understand the RTL artifacts in this patch. Why do some lines suddenly render the closing '>' of the entity definition in RTL? The original code doesn't. Given that this is an external contribution, I'm not sure if this is a good thing to take. And, do these changes really block the release?

(In reply to comment #5) > (From update of attachment 320984 [details] [diff] [review]) > I don't understand the RTL artifacts in this patch. Why do some lines suddenly > render the closing '>' of the entity definition in RTL? The original code > doesn't. There aren't any bidi control codes in the entities themselves. It's a rendering issue (caused by bug 263359 and the fact that the new lines are followed by numerals).

Comment on attachment 320986 [details] [diff] [review] /l10n/he/extensions (14/05/08) (In reply to comment #4) > This patch should be obsolete, You right. I'm marking as obsolete. > and it's not the right thing to do from a > mark-up point of view. Marking removed entries in comment? As I don't know about any utility that can keep a glossary file for me, I mark the strings in comment for about a week before removing completely.

(In reply to comment #5) > I don't understand the RTL artifacts in this patch. Why do some lines suddenly > render the closing '>' of the entity definition in RTL? The original code > doesn't. As smontagu said, it is correct without any control characters. You can make sure it is formatted correctly by looking on the patch from the diff view.

i'd like to note that Emanuel Lotem*'s translation of the first rule of robotics is as follows: לא יפגע רובוט לרעה בבן אדם, ולא יניח, במחדל, שאדם יפגע. also, in SeaMonkey, i translated "release notes" as הערות למהדורה. --- * Emanuel Lotem is one of the most prominent translators of sci-fi books to Hebrew. the rules of robotics, as they appear in the hebrew edition of I, Robot (Keter Books, 2004), were translated by him.

(In reply to comment #9) > i'd like to note that Emanuel Lotem*'s translation of the first rule of > robotics is as follows: > לא יפגע רובוט לרעה בבן אדם, ולא יניח, במחדל, > שאדם יפגע. Sounds like we are translating sci-fi books, not software products! That parse also appears in he.wikipedia.org. I've updated my local CVS repository with the changes, but please note that it not currently appear on the diff.

Blocking bug 415606 says that we shouldn't release the Hebrew version of Firefox 3 without these patches applied. Is that what you mean? I'm not sure how likely this is, but if RC1 was the final release, this would mean that we wouldn't want to ship Hebrew in Firefox 3.0.

I don't think that's what we want, if we can release and then improve the l10n with dot releases.

Updated patch. I've also added some minor fixes. Will update in few moments the bug dependencies.

I'm adding bug 435553 to the queue. Is it clear enough to look for the patch there? (attachment 322353 [details] [diff] [review])

Comment on attachment 321801 [details] [diff] [review] patch - /l10n/he/{extensions,browser,toolkit,netwerk} - 20/05/08 (diff -u) r-, extensions/reporter/chrome/reporterOverlay.dtd is fixed for a while already, please cvs update your tree and remove all resulting conflicts. We shouldn't have changes to help files anymore, either, as that's on SUMO, and the comment cleanups aren't really required either. I'd like to see the patches for search and region.properties in their respective bugs, too, shouldn't be too hard to exclude them from this diff.

We'll need a revised patch by tomorrow in order to land it for RC2, which we're going to do, as per Firefox 3 meeting just now. Please make sure to cvs update before you create the diff to make sure you have the latest status of the tree, and make sure that potential merge conflicts are resolved.

I've removed the searchplugin and some help stuff from this patch. As for the searchplugin, please land it, as the current one is broken. (bug 416535)

Comment on attachment 322831 [details] [diff] [review] patch - /l10n/he/{extensions,browser,toolkit,netwerk} - 28/05/08 (diff -u) r/a=me for immediate landing. Please use a check-in comment referencing this bug and my review/approval

I'm sorry I'm late, but this is a required change, as the string seems to be broken. :( Please land for RC2.

Yet another typo. Sorry for that.

Comment on attachment 322841 [details] [diff] [review] about:mozilla r/a=me for immediate landing

Thanks Axel! Marking bug as fixed.