Closed
Bug 433851
Opened 16 years ago
Closed 16 years ago
Flag <select> not disabled even though user can't request or change flag
Categories
(Bugzilla :: Attachments & Requests, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: reed, Assigned: reed)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
There are three different possible <select>s in template/en/default/flag/list.html.tmpl that can be used for flags. All but one has a check that makes the <select> disabled if the user can't request it. Not sure why that one was missed, but it should be fixed.
Attachment #321044 -
Flags: review?(LpSolit)
Comment 1•16 years ago
|
||
I see no reason to mark it as disabled, even if you cannot change it. The reason this one is not disabled is because this flag already exists while in the other two cases, the flag doesn't exist yet. In the case described in this bug, the user would see a flag with a single option, which is the one already selected. I'm fine with that.
Assignee | ||
Comment 2•16 years ago
|
||
Change the other two <select>s instead rather than modifying the first one incorrectly.
Attachment #321044 -
Attachment is obsolete: true
Attachment #321092 -
Flags: review?(LpSolit)
Attachment #321044 -
Flags: review?(LpSolit)
Comment 3•16 years ago
|
||
Comment on attachment 321092 [details] [diff] [review]
patch - v2
Tested on both 3.0.4 and 3.1.4. r=LpSolit
Attachment #321092 -
Flags: review?(LpSolit) → review+
Updated•16 years ago
|
Severity: normal → minor
Flags: approval3.0+
Flags: approval+
Target Milestone: --- → Bugzilla 3.0
Assignee | ||
Comment 4•16 years ago
|
||
tip:
Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v <-- list.html.tmpl
new revision: 1.32; previous revision: 1.31
done
BUGZILLA-3_0-BRANCH:
Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v <-- list.html.tmpl
new revision: 1.27.2.3; previous revision: 1.27.2.2
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment on attachment 321092 [details] [diff] [review]
patch - v2
>
Comment on attachment 321092 [details] [diff] [review]
patch - v2
>
Comment on attachment 321092 [details] [diff] [review]
patch - v2
>
Comment on attachment 321044 [details] [diff] [review]
patch - v1
>
Comment on attachment 321044 [details] [diff] [review]
patch - v1
>
Comment 10•12 years ago
|
||
Comment on attachment 321044 [details] [diff] [review]
patch - v1
>
You need to log in
before you can comment on or make changes to this bug.
Description
•