Closed Bug 434008 Opened 17 years ago Closed 16 years ago

Readonly custom field texts appear too small

Categories

(Bugzilla :: User Interface, defect, P1)

3.1.4

Tracking

()

RESOLVED FIXED
Bugzilla 3.2

People

(Reporter: guy.pyrzak, Assigned: guy.pyrzak)

References

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

On edit bug custom fields appear with font-size:small, this makes the text hard to see.
Attached patch Patch v1 (obsolete) (deleted) β€” β€” Splinter Review
Assignee: ui → guy.pyrzak
Status: NEW → ASSIGNED
Attachment #321211 - Flags: review?(mkanat)
Attachment #321211 - Flags: review?(LpSolit)
(In reply to comment #0)
> On edit bug custom fields appear with font-size:small, this makes the text hard
> to see.

Really? I don't see this. Do you have a screenshot and could you point me to the place which makes the text to be smaller?
Attached image Screen shot of problem (deleted) β€”
regression caused by bug 357315. is it ok just to remove that class?
104                <div class="uneditable_textarea">[% value FILTER wrap_comment(60)
105                                                          FILTER html %]</div>
Depends on: 357315
Keywords: regression
It's rather a regression due to bug 388723.
Depends on: 388723
No longer depends on: 357315
Comment on attachment 321211 [details] [diff] [review]
Patch v1

As discussed on AIM, I don't think this is the right fix. The font being different and of a different size but be fixed at its root.
Attachment #321211 - Flags: review?(LpSolit)
Comment on attachment 321211 [details] [diff] [review]
Patch v1

Is this a problem with .uneditable_textarea, or with .field_value?
Comment on attachment 321211 [details] [diff] [review]
Patch v1

If this is a problem with .uneditable_textarea, it should just be fixed there.
Attachment #321211 - Flags: review?(mkanat) → review-
I hope this bug summary will better reflect what the problem is, i.e. that the text of custom fields displayed as readonly is too small, not the field itself (e.g. the width of text forms).
Summary: Custom fields appear too small → Readonly custom field texts appear too small
Yeah, this is super-simple to fix, please fix it.
Priority: -- → P1
Severity: normal → minor
Flags: blocking3.2+
By looking at the uneditable_textarea class, it seems the problem is not font-size:small (which doesn't exist for this class), but rather because it has font-family:monospace. monospace can have a different font size than "normal" text, explaining the difference. Probably it's unappropriate to define font-family here, i.e. it should only be used by the bz_comment_text class.
pyrzak, to be sure: you only see this problem with readonly textarea, right? Or do you also see this problem with other readonly text fields? If it's only about textarea (which seems to be the case by looking at classes defined in CSS files), then the bug summary should be updated to reflect that (because it's currently confusing, and the checkin message will also be).
Um... i think this bug is fixed. can someone verify?
Attached patch Patch v2 (deleted) β€” β€” Splinter Review
Attachment #321211 - Attachment is obsolete: true
Attachment #341560 - Flags: review?(mkanat)
Attachment #341560 - Flags: review?(mkanat) → review+
Please add a space after the colon on checkin. (I've nitted that like a zillion times, now, BTW.)
Flags: approval3.2+
Flags: approval+
Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.53; previous revision: 1.52
done

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.47.2.5; previous revision: 1.47.2.4
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: