Closed
Bug 435604
Opened 17 years ago
Closed 17 years ago
gcc build failure in nsNativeThemeWin.cpp
Categories
(SeaMonkey :: Themes, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 439603
People
(Reporter: Mook, Assigned: Mook)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
Gavin
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
mozilla/widget/src/windows/nsNativeThemeWin.cpp: In member function ‘virtual PRBool nsNativeThemeWin::GetWidgetPadding(nsIDeviceContext*, nsIFrame*, PRUint8, nsMargin*)’:
mozilla/widget/src/windows/nsNativeThemeWin.cpp:1605: warning: jump to case label
mozilla/widget/src/windows/nsNativeThemeWin.cpp:1602: error: crosses initialization of ‘SIZE size’
mozilla/widget/src/windows/nsNativeThemeWin.cpp:1613: warning: jump to case label
mozilla/widget/src/windows/nsNativeThemeWin.cpp:1602: error: crosses initialization of ‘SIZE size’
Needs extra braces.
Attachment #322402 -
Flags: review?(gavin.sharp)
|
||
Updated•17 years ago
|
Attachment #322402 -
Flags: review?(gavin.sharp) → review+
|
|
||
Comment 2•17 years ago
|
||
Not that big of a deal, only crazy people build windows widget code with gcc :)
|
||
Updated•17 years ago
|
Assignee: nobody → mook.moz+mozbz
Flags: wanted1.9.0.x?
|
|
||
Comment 3•17 years ago
|
||
Oops, sorry I somehow read wanted1.9.0.x as wanted1.9.1... :-/
Flags: wanted1.9.0.x?
|
||
Comment 4•17 years ago
|
||
Comment on attachment 322402 [details] [diff] [review]
add braces
sr=dbaron
Attachment #322402 -
Flags: superreview+
Umm, I think that's all the reviews I need? (syntax only bustage fix anyway). Also, I have no idea what keyword to use to ask people to push to mozilla-central.
Keywords: checkin-needed
No longer blocks: 435825
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → DUPLICATE
|
||
Updated•16 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•