Closed Bug 43588 Opened 25 years ago Closed 24 years ago

nsRepeatService held past XPCOM shutdown in static nsCOMPtr

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Platform:
x86
Windows 98
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla0.9

People

(Reporter: dbaron, Assigned: dbaron)

References

(Blocks 1 open bug)

Details

(Keywords: memory-leak, topembed+, Whiteboard: [tind-mlk][nsbeta3-])

nsRepeatService::gInstance is held past XPCOM shutdown in a static nsCOMPtr. It is defined at http://lxr.mozilla.org/seamonkey/source/layout/xul/base/src/nsRepeatService.h#55 See bug 43561 for more info.
Blocks: 43561
Keywords: mlk
eric, why have the static GetInstance() method? Isn't this exactly what the ServiceManager does for you? You shouldn't be re-implementing it yourself.
Assignee: trudelle → evaughan
Whiteboard: [tind-mlk]
Blocks: 38671
mass-moving all evaughan non-nsbeta3+ bugs to 'Future' milestone (per trudelle).
Target Milestone: --- → Future
can't we make it a raw static and release it when a service w/ scope to it's lifetime is shutdown?
Keywords: nsbeta3
This is very easy to fix. Just a few lines. But I would have to get it beta3+ to fix it. :)
Status: NEW → ASSIGNED
Why is this worth any time/risk?
nsbeta3-, if shown to be necessary, we may be able to reconsider this later.
Whiteboard: [tind-mlk] → [tind-mlk][nsbeta3-]
Taking this bug since I attached a proposed fix to bug 43582.
Assignee: evaughan → dbaron
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla0.9
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Keywords: topembed+
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.