User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008053100 Minefield/3.0pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008053100 Minefield/3.0pre At first run, the description of Feed View is not displayed. This bug makes that a new user understands Feed View difficult. Reproducible: Always Steps to Reproduce: 1. New Profile or set value empty/true browser.feeds.showFirstRunUI 2. visit this page http://www.opera.com/ 3. left click feed button on Location Bar Actual Results: The description of Feed View is not displayed. Expected Results: The description of Feed View is displayed.

1. {Build ID: 2008032405} 2. Bug 360529 3. {Build ID: 2008032505} 4. Bug 425010 5. from {Build ID: 2008032605} to Now

a part of red frame

Probably caused by bug 360529. -- Error: uncaught exception: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getComplexValue]" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: file:///C:/Program%20Files/Mozilla%20Firefox/components/FeedWriter.js :: FW__setSelectedHandler :: line 844" data: no] --

Hmm, that was supposed to be fixed by bug 425010, which has been verified as fixed, but I can definitely see this problem on the latest build, so I'm guessing that it somehow regressed again?

We're dealing with a wrapper here, so the property doesn't work. I first tried just using setAttribute with the existing <description>s, but with that fix the styling was incorrect (both strings on one line, no space between them), which I assume was caused by the change in bug 400064 to start using a <description> instead of a <div>. I'm reverting that change and using <div>s again. The styling is still a bit odd (at least with pinstripe), but that can be dealt with separately.

(In reply to comment #4) > Hmm, that was supposed to be fixed by bug 425010 The exception in comment 3 isn't related to bug 425010, or to the bustage in this bug as far as I can tell. Can you reproduce it? Worth filing another bug, not sure why getComplexValue would be throwing there.

(In reply to comment #6) > (In reply to comment #4) > > Hmm, that was supposed to be fixed by bug 425010 > > The exception in comment 3 isn't related to bug 425010, or to the bustage in > this bug as far as I can tell. Can you reproduce it? Worth filing another bug, > not sure why getComplexValue would be throwing there. > Oops, you're right. I guess I skimmed that bug too quickly.

Comment on attachment 323255 [details] [diff] [review] patch r=mano

Gavin, if you need help checking this in, just ask. :P

I don't need help checking it in, I haven't checked it in because I haven't created a test for it yet. If someone wants to do that, I wouldn't be opposed!

I'm sorry. I had misunderstood the review & checkin system. :-(

Gah, this shipped in Firefox 3 because I never got around to writing a test for it. We should just land it...

http://hg.mozilla.org/mozilla-central/rev/ca6426f959b3 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b10e8bad4e4a

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090207 Minefield/3.2a1pre {Build ID: 20090207114155} Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b3pre) Gecko/20090207 Shiretoko/3.1b3pre {Build ID: 20090207123315} This seems to have been fixed.

Verified fixed on the 1.9.1 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090210 Shiretoko/3.1b3pre and : Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090210 Shiretoko/3.1b3pre.