Closed
Bug 43687
Opened 24 years ago
Closed 22 years ago
Leakage noise fix for class CNewlineToken
Categories
(Core :: DOM: HTML Parser, defect, P3)
Tracking
()
RESOLVED
INVALID
mozilla1.0.1
People
(Reporter: inaky.gonzalez, Assigned: harishd)
Details
(Keywords: memory-leak)
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Class CNewlineToken allocates an static variable at method GetStringValueXXX()
which adds noise to the leak logs. With this patch I move that variable to be a
class static, and via a instances count, it is allocated or deleted, as soon as
any object is created/all of them are destroyed.
I´m considering this would be a good candidate to be #ifdef DEBUG, as I could
be hitting performance.
Reporter | ||
Updated•24 years ago
|
Reporter | ||
Comment 1•24 years ago
|
||
Okay, here is the patch, didn´t have time to post it last Friday. Again, I
mention this could be a good candidate to be #ifdef´ed DEBUG, unluess you guys
disagree.
Reporter | ||
Comment 2•24 years ago
|
||
Reporter | ||
Comment 3•24 years ago
|
||
Carl has a (I think much better) sollution for this, simply using an static
nsString. I can recall you had some arguments against static objects, but I
cannot remember if it was limited to nsCOMPtr or what was the point exactly.
Could you guys ellaborate on it?
Thx,
Comment 4•24 years ago
|
||
Comment 6•23 years ago
|
||
inaky.gonzalez@intel.com: Are you still working on this bug ? Can you please add a
comment ?
Reporter | ||
Comment 7•23 years ago
|
||
I have not done any work on mozilla for a long time already, so I
cannot add any insight.
Comment 8•23 years ago
|
||
-> default owner (via mail:Inaky Perez Gonzalez has no time for this)
Assignee: inaky.gonzalez → harishd
The code has changed, a lot, since the bug was filed and I don't think it's an
issue anymore. If you disagree please reopen the bug. For now marking INVALID.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•