Closed
Bug 437869
Opened 16 years ago
Closed 16 years ago
Remove the RDF global object
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0a3
People
(Reporter: jminta, Assigned: jminta)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
At this point, we've reduced our rdf usage to the point where we can get rid of the global "RDF" object. We still have to re-route some of the calls through GetMsgFolderFromUri, but most of the functions can be restructured to just pass folders instead of URIs.
Attachment #324211 -
Flags: superreview?(bienvenu)
Attachment #324211 -
Flags: review?(bienvenu)
|
Assignee | |
Comment 1•16 years ago
|
||
Comment on attachment 324211 [details] [diff] [review]
patch v1
Shoot, I forgot I submitted a bunch of this in another bug...
Attachment #324211 -
Flags: superreview?(bienvenu)
Attachment #324211 -
Flags: review?(bienvenu)
|
|
Assignee | |
Comment 2•16 years ago
|
||
As it turns out, there are actually 2 copies of the same global object floating around. One is defined in messengerdnd.js, and this patch eliminates this copy. The second is defined in mailWindow.js, and that one can be eliminated once bug 441077 lands.
Attachment #324211 -
Attachment is obsolete: true
Attachment #327725 -
Flags: superreview?(bienvenu)
Attachment #327725 -
Flags: review?(bienvenu)
|
||
Updated•16 years ago
|
Attachment #327725 -
Flags: superreview?(bienvenu)
Attachment #327725 -
Flags: superreview+
Attachment #327725 -
Flags: review?(bienvenu)
Attachment #327725 -
Flags: review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
This patch eliminates both global rdf objects, channeling people through GetMsgFolderFromUri (which is now rdf free!) instead.
Attachment #327725 -
Attachment is obsolete: true
Attachment #337121 -
Flags: superreview?(bienvenu)
Attachment #337121 -
Flags: review?(bienvenu)
|
|
||
Updated•16 years ago
|
Attachment #337121 -
Flags: superreview?(bienvenu)
Attachment #337121 -
Flags: superreview+
Attachment #337121 -
Flags: review?(bienvenu)
Attachment #337121 -
Flags: review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Pushed as 363:a28e195fb616
Regression testing should focus on drag-n-drop. Any js console errors that happen during that could be ascribable to this patch.
|
|
Assignee | |
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Target Milestone: --- → Thunderbird 3.0b1
|
||
Updated•13 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•