Closed Bug 438526 Opened 16 years ago Closed 16 years ago

Opening links with target="_search" in the sidebar is broken, and should be removed

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.5

People

(Reporter: philor, Assigned: philor)

References

()

Details

(Keywords: regression, verified1.9.0.2)

Attachments

(2 files)

Attached file Testcase (deleted) —
Firefox still intends to open links with target="_search" in the sidebar (see URL field), but instead opens them in a new tab, after some sort of ugly failure that shows up in the error console as [[[ Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: XStringBundle :: getString :: line 17" data: no] ]]]] Not sure when, but I'm initially suspicious of bug 370765.
Flags: blocking-firefox3.1?
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.js&rev=1.1033&mark=4828#4812 bug 375243 removed webPanels from browser strings - -# Default name for the Web Panels sidebar -webPanels=Web Panels -
Thanks, but couldn't you have found that someone other than me broke it?
Assignee: nobody → philringnalda
Attached patch Fix v.1 (deleted) — Splinter Review
IE7 no longer supports target="_search", and over the 15 months since I broke it, I'm the only person who noticed, and I was just using it as a convenient way of testing something else. Time to put it to bed.
Attachment #324734 - Flags: review?(gavin.sharp)
Status: NEW → ASSIGNED
Summary: Links with target="_search" no longer open in sidebar → Opening links with target="_search" in the sidebar is broken, and should be removed
Target Milestone: --- → Firefox 3.1
Flags: blocking-firefox3.1?
Comment on attachment 324734 [details] [diff] [review] Fix v.1 driveby r=me, die etc
Attachment #324734 - Flags: review?(gavin.sharp) → review+
changeset: 15357:6ee23de41631
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Attachment #324734 - Flags: approval1.9.0.1?
IE7 does support it. Go to the options and see whether "Enable web sites to use the search pane" is checked. I noticed it although I only reported it 2 months ago. https://bugzilla.mozilla.org/show_bug.cgi?id=430095 One of my web sites in particular ( http://lookwayup.com/ ) makes significant use of it and I'm not looking forward to the changes in the coding and the help required to tell my disproportionately Mozilla users that they are losing this feature.
Attachment #324734 - Flags: approval1.9.0.1? → approval1.9.0.2?
Comment on attachment 324734 [details] [diff] [review] Fix v.1 Approved for 1.9.0.2. Please land in CVS. a=ss
Attachment #324734 - Flags: approval1.9.0.2? → approval1.9.0.2+
Phil is out so someone will have to land this on 1.9 for him.
Keywords: checkin-needed
Bunch of lazy SOBs, the lot of you... browser/base/content/browser.js 1.1036
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.2) Gecko/2008090212 Firefox/3.0. 3.02 no longer gets the error: Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: XStringBundle :: getString :: line 17" data: no] Behavior is otherwise the same.
Target Milestone: Firefox 3.1 → Firefox 3.5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: