Closed
Bug 439004
Opened 17 years ago
Closed 17 years ago
Change CanPlaceFloatNow to LineIsEmpty
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
Details
Attachments
(1 file)
|
(deleted),
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
Extracted from bug 50630. CanPlaceFloatNow tests whether the current inline content width is nonzero. Like most checks for zero dimensions, this is wrong and we should be testing logical emptiness instead. For example, we wouldn't want an element to be treated as empty because it has negative dimensions that exactly cancel out its positive dimensions.
This fixes a bug where we trim whitespace in a line that starts with zero-width but not logically empty content, such as a zero-width image.
|
Assignee | |
Comment 1•17 years ago
|
||
As described.
Attachment #324918 -
Flags: superreview?(dbaron)
Attachment #324918 -
Flags: review?(dbaron)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 324918 [details] [diff] [review]
fix
r+sr=dbaron
Attachment #324918 -
Flags: superreview?(dbaron)
Attachment #324918 -
Flags: superreview+
Attachment #324918 -
Flags: review?(dbaron)
Attachment #324918 -
Flags: review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Checked in
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•17 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•