From <http://mxr.mozilla.org/mozilla/source/mail/base/content/mail-folder-bindings.xml> To ?? Dan, Karsten, Can you write where to move it exactly ? Then confirm the bug.

Require reviewed cvscopy file for this.

Reopen this when you have specific directions for us and module owner approval for the destination module.

How about mailnews/base/resources/content?

Yes, that's where our shared mailWidgets.xml are located as well.

Do we need to coordinate this move with packaging changes?

(In reply to comment #6) > Do we need to coordinate this move with packaging changes? "Yes (+/-)": see my Av1-TB patch in bug 438647 ;-)

Comment on attachment 325856 [details] (Av1) <mail-folder-bindings.xml> r=dmose

Reed, any ETA for this move ?

Sorry for not noticing this bug before, but how did this file get to be called mail-folder-widgets.xml in the first place? This does not seem to be typical mailnews style, except for some exceptions: * Suite pref panels have a pref- prefix * Suite sidebar panels have a -panel suffix * Account manager panes have an am- prefix * Account wizard scripts have an aw- prefix * mail-offline.js

A fair point. msgFolderWidgets.xml, perhaps?

We've /mailnews/base/search/resources/content/searchWidgets.xml /mailnews/base/resources/content/mailWidgets.xml so how about just folderWidgets.xml?

Sounds reasonable to me.

Av1, with comment 12 suggestion(s).

(In reply to comment #9) > Reed, > any ETA for this move ? Sorry, bug got lost in bugmail... Do you want me to do the first move now, or wait until the second one has been reviewed and do them together?

(In reply to comment #15) > Sorry, bug got lost in bugmail... Do you want me to do the first move now, or It seems it was for the better, this time ;-> > wait until the second one has been reviewed and do them together? Let's wait for the new reviews.

Comment on attachment 327047 [details] [diff] [review] (Av2) <folderWidgets.xml> [Checkin: Comment 22] r=dmose

Is this ready for us to push?

(In reply to comment #18) > Is this ready for us to push? Yep.

(In reply to comment #19) > (In reply to comment #18) > > Is this ready for us to push? > > Yep. If you can, (preemptively) check in bug 438647 Av1a-TB patch too. Thanks.

Ping, for checkin(s) ?

# /opt/cvsmgmt/bulk-copy.pl </opt/cvsmgmt/439058.script Copying mozilla/mail/base/content/mail-folder-bindings.xml -> mozilla/mailnews/base/resources/content/folderWidgets.xml ... branchlist =

V.Fixed

We need to CVS remove mail-folder-bindings.xml once bug 438647 is completely fixed for a few days. Whoever does that then should note it here as well.

Per comment 24, actually remove the old file, after comment 22 copy to new location.

(In reply to comment #25) > Created an attachment (id=332031) [details] > (Bv1) Hg-remove old file > > Per comment 24, > actually remove the old file, after comment 22 copy to new location. Open a new bug under the appropriate product for this and make sure you get appropriate reviews.

(In reply to comment #26) I filed bug 450044.