Closed
Bug 439619
Opened 16 years ago
Closed 16 years ago
Extension manager "Install..." fails if appendFilter iface not implemented
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a2
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
Extension manager Install from file functionality fails if AppendFilter not implemented in FilePicker.
Attachment #325395 -
Flags: review?(robert.bugzilla)
|
||
Comment 1•16 years ago
|
||
On what platforms is appendFilter not implemented?
|
Assignee | |
Comment 2•16 years ago
|
||
Currently it is not implemented on maemo-gtkmozembed filepicker...
https://garage.maemo.org/svn/browser/mozilla/trunk/libgtkembedmoz/gtk/src/EmbedFilePicker.cpp
Of course it is not a big issue, but timeless says that it better to make this thing not critical and move it into try condition.
|
|
||
Comment 3•16 years ago
|
||
I would suggest that it might be better to just make the appendFilter(s) methods successful no-ops. I think that will make lives a lot easier for extension authors wanting to port their extension to the mobile platform
mossop: there's no contract that says what it should do. it's very easy for this not to be implemented on an embedding platform (and the right default behavior for not implemented is an exception).
we will probably make our impl to return ns_ok, however we're asking you to make this change anyway.
|
||
Updated•16 years ago
|
Attachment #325395 -
Flags: review?(robert.bugzilla) → review+
|
||
Updated•16 years ago
|
Product: Firefox → Toolkit
|
|
||
Comment 5•16 years ago
|
||
Is there a reason this hasn't landed yet?
|
||
Updated•16 years ago
|
Assignee: nobody → romaxa
|
|
||
Comment 7•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2
You need to log in
before you can comment on or make changes to this bug.
Description
•