When investigating test failures for bug 436349, Mark found out that bug 231754, "Mac: pressing up/down arrow key does not move caret to beginning/end of url bar or text box", has apparently only been fixed for toolkit autocomplete and not xpfe, so tests for that fail on SeaMonkey.

Basically this needs Mac testing, so I'll take any two reviews ;-)

Well its better ;-) out of the 7 previous failures I now see only 3: *** 423 ERROR FAIL | no value up keypress event not fired | got true, expected false | chrome://mochikit/content/chrome/toolkit/content/tests/chrome/test_autocomplete.xul *** 427 ERROR FAIL | no value down keypress event not fired | got true, expected false | chrome://mochikit/content/chrome/toolkit/content/tests/chrome/test_autocomplete.xul *** 442 ERROR FAIL | value down with caret in middle again keypress event not fired | got true, expected false | chrome://mochikit/content/chrome/toolkit/content/tests/chrome/test_autocomplete.xul

This should now pass all the mochitests. * Improved documentation * Changed a return from false to true

Comment on attachment 328131 [details] [diff] [review] Revised patch one down ;-) r=me.

Comment on attachment 328131 [details] [diff] [review] Revised patch Works fine. I have not checked if the tests pass, though. One small thing: >+ // For compatibility for toolkit we now have to predict which "For compatibility with toolkit"?

Fix checked in.

Looks good on the unit test box, which now succeeds on those tests. Could you land in mozilla-central as well so we don't lose the fix when switching to Mercurial?

(In reply to comment #7) > Looks good on the unit test box, which now succeeds on those tests. You confused me, becuase it was chrome tests that I was fixing ;-) > Could you land in mozilla-central as well so we don't lose the fix when > switching to Mercurial? Bah, first editor/ui, and now this... btw I haven't installed even hg yet.

> > Could you land in mozilla-central as well so we don't lose the fix when > > switching to Mercurial? > Bah, first editor/ui, and now this... btw I haven't installed even hg yet. > http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/xpfe/components/autocomplete/resources/content/autocomplete.xml&root=/cvsroot versus http://hg.mozilla.org/mozilla-central/?log/tip/xpfe/components/autocomplete/resources/content/autocomplete.xml --> rev 1.165-1.168 of the cvs trunk version is missing in the mozilla-central file...

Comment on attachment 328131 [details] [diff] [review] Revised patch clearing seemingly obsolete review requests.

Patch checked into mozilla-central in Bug 443837

Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/c188a0d1e01c Allow up/down arrows to be home/end on the Mac r=Standard8,stefanh [p=Neil]