See the url, when setting the "nomatch" attribute, toolkit's autocomplete sets it on the popup, rather than the textbox/autocomplete element. This basically makes the action useless as if there are no matches then there won't be a popup. See also http://mxr.mozilla.org/seamonkey/search?string=nomatch for current uses (none). This is needed for a nice implementation of bug 441526.

This moves the attribute setting from the popup to the main autocomplete element. Test included to ensure correct functionality. I'll probably be extending the test in bug 441526 which is why I named it generically.

Comment on attachment 326530 [details] [diff] [review] The fix and test I won't have time to look at this soon, punting to Enn

Comment on attachment 326530 [details] [diff] [review] The fix and test >+netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect"); This is a chrome test. Why are you asking for privileges throughout this test? >+ is(autocomplete.hasAttribute("nomatch"), false); There should be a description of the test as the third argument. Similarly for the other 'is' calls. >+ is(autocomplete.hasAttribute("nomatch"), true); >+ is(autocomplete.getAttribute("nomatch"), "true"); Save time and just check the second case only.

I addressed Neil's comments and this is what I have checked in.

I checked this in earlier today and had to back it out again due to memory leaks. I think the problem was to do with how I was handling the component registration within the chrome level tests. I have an alternative way that I am currently testing.

When I checked in the previous version it turned the tinderboxes orange due to a memory leak, I investigated and it was due to having the result being created inline in the startSearch function, as http://developer.mozilla.org/en/docs/Using_XPCOM_in_JavaScript_without_leaking#Things_not_to_do suggests. So I have moved it to outside and created it as an object, and the test no longer leaks. Requesting review again as the test has changed slightly from what it was.

Comment on attachment 329832 [details] [diff] [review] The fix and test v3 >+nsAutoCompleteSimpleResult.prototype = { >+ _param: null, Did you mean "" here?

(In reply to comment #7) > (From update of attachment 329832 [details] [diff] [review]) > >+nsAutoCompleteSimpleResult.prototype = { > >+ _param: null, > > Did you mean "" here? > Patch checked in with this fixed.