Trying to do some testing for bug 419143, when I came across the fact that the filter dialog was unable to select a folder for message filters. Although I am hesitant to request something blocking-a2 at this point, any news user will hit this instantly which makes triaging many filters difficult, since many users prefer newsgroup filters.

I have my news.mozilla.org account listed in the tree, though, I'm seeing other errors in the dialog. Given http://mxr.mozilla.org/seamonkey/source/mail/base/content/mail-folder-bindings.xml#107 I'm surprised about this bug, since it should return true for all news accounts.

The news account appears, but what doesn't appear is the specific newsgroups underneath the news account.

On closer analysis, I think this is a regression of an older bug...

Not taking this bug, but this is some preliminary work for whoever does work on this. What's not fixed are these: 1. I don't know how to use the DOM to create a reference to the entity, short of just slapping in an innerHTML statement. 2. Selection doesn't appear to work right, but it didn't before this patch anyways; I can't tell if it's the same issue though.

Comment on attachment 326734 [details] [diff] [review] First start + // Set up the first rows + var headNode = document.createElement("menuitem"); + // this ain't quite right + headNode.setAttribute("label", "&choosethisnewsserver.label;"); + headNode._folder = folder; + popup.appendChild(headNode); + popup.appendChild(document.createElement("menuseparator")); Use showFileHere="true" and fileHereLabel="&foo;" to accomplish this.

Joshua, are you able to take this?

(In reply to comment #6) > Joshua, are you able to take this? I'll try tackling this within the next week.

It feels like every time I fix an issue 2 more crop up... 1. I'm pretty sure that some errors outside this bug already exist. 2. The bigger problem is that in his zeal to rid the filter dialog of RDF, jminta completely ignored the issue that folders can have filters, meaning that servers are passed around everywhere instead of folders (the root folder representing the server). Fixing this is going to take a bit. 3. Bitrot galore. 4. I now have the labels and other UI working, and in a way that I think is satisfactory (modulo what to do in an error case). What I don't have is the backend.

This essentially attempts to bring the filter dialog back to the TB 2.0 model, and allows for extensibility in the modification of mail-folder-bindings.xml. I'm pretty sure we have another bug going on with RSS accounts in the filter dialog (the "run filters on" menu seems to be causing an error), but that's outside the scope of this bug.

Comment on attachment 335660 [details] [diff] [review] Patch, v1 - * @param aServer the nsIMsgIncomingServer that was selected + * @param aFolder the nsIMsgIncomingServer that was selected this comment seems wrong + * is a comma-delimited list of labels corresponding in order with + * the servers to expand form expandFolders. "expand from" ? Is it considered good js style to redeclar vars like this? + var shouldExpand = function (e) { return true; }; + } else if (this.getAttribute("expandFolders") == "false") { + var shouldExpand = function (e) { return false; }; similarly with labels below? I've tried the patch and it seems to work well, so I just have those style questions...

Updated the patch with bienvenu's style comments.

Comment on attachment 336089 [details] [diff] [review] Updated patch thx, Joshua

Checked in, changeset cfaac96a1c73.